Bug 195516

Summary: Optimizing loads when creating new pages
Product: WebKit Reporter: Jiewen Tan <jiewen_tan>
Component: WebKit Misc.Assignee: Jiewen Tan <jiewen_tan>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, cgarcia, commit-queue, darin, ews-watchlist, ggaren, gustavo, jiewen_tan, mcatanzaro, tsavell, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Jiewen Tan
Reported 2019-03-09 01:17:31 PST
Optimizing loads when creating new pages.
Attachments
Patch (22.55 KB, patch)
2019-03-09 01:28 PST, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Patch (22.56 KB, patch)
2019-03-10 00:06 PST, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Patch (22.56 KB, patch)
2019-03-10 00:28 PST, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-03-09 01:20:47 PST
<rdar://problem/48738086>
Jiewen Tan
Comment 2 2019-03-09 01:28:08 PST
Created attachment 364123 [details] Patch
Jiewen Tan
Comment 3 2019-03-09 01:28:52 PST
The internal counterpart is within: <rdar://problem/46325687>.
EWS Watchlist
Comment 4 2019-03-09 01:29:32 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Jiewen Tan
Comment 5 2019-03-10 00:06:09 PST
Created attachment 364175 [details] Patch
Jiewen Tan
Comment 6 2019-03-10 00:28:26 PST
Created attachment 364178 [details] Patch
Michael Catanzaro
Comment 7 2019-03-10 10:42:08 PDT
Comment on attachment 364178 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364178&action=review > Source/WebKit/UIProcess/WebPageProxy.h:2191 > +#if HAVE(LOAD_OPTIMIZER) > +WEBPAGEPROXY_LOADOPTIMIZER_ADDITIONS_2 > +#endif How do these hooks work? It's strange that we would have non-open source code tightly coupled to open source like this. It's one thing to depend on an internal library, or to provide APIs for use by internal code, but just #including secret code into WebKit internals like this seems... unusual. What gets optimized?
Darin Adler
Comment 8 2019-03-10 13:00:54 PDT
Comment on attachment 364178 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364178&action=review r+ so Jiewen can keep making progress >> Source/WebKit/UIProcess/WebPageProxy.h:2191 >> +#endif > > How do these hooks work? > > It's strange that we would have non-open source code tightly coupled to open source like this. It's one thing to depend on an internal library, or to provide APIs for use by internal code, but just #including secret code into WebKit internals like this seems... unusual. > > What gets optimized? I understand your unease. But this has happened multiple times before before when an engineer at Apple started development on something that Apple wasn't ready to reveal. I think it’s OK for now; we can discuss it in more detail when someone from Apple upstreams everything. And it’s all inside an #if.
Jiewen Tan
Comment 9 2019-03-10 20:14:21 PDT
Comment on attachment 364178 [details] Patch Thanks Darin for r+ this patch.
WebKit Commit Bot
Comment 10 2019-03-10 20:41:19 PDT
Comment on attachment 364178 [details] Patch Clearing flags on attachment: 364178 Committed r242697: <https://trac.webkit.org/changeset/242697>
WebKit Commit Bot
Comment 11 2019-03-10 20:41:21 PDT
All reviewed patches have been landed. Closing bug.
Truitt Savell
Comment 12 2019-03-11 08:55:12 PDT
Reverted r242697 for reason: Broke internal builders. Committed r242705: <https://trac.webkit.org/changeset/242705>
Jiewen Tan
Comment 13 2019-03-11 10:41:21 PDT
(In reply to Truitt Savell from comment #12) > Reverted r242697 for reason: > > Broke internal builders. > > Committed r242705: <https://trac.webkit.org/changeset/242705> Thanks for the heads up. I forgot that I have to land the OpenSource and Internal changes together. Will hold the same patch after the Internal one is ready to land.
Jiewen Tan
Comment 14 2019-03-11 17:58:03 PDT
Committed r242760: <https://trac.webkit.org/changeset/242760>
Note You need to log in before you can comment on or make changes to this bug.