Summary: | [WHLSL] Hook up the compiler to our WebGPU implementation | ||||||||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||||||||||||||||||||||||||||||||||||||||||||
Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||||||||||||||||||||||||||||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||||||||||||||||||||||||||||||||
Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, commit-queue, dbates, dino, esprehn+autocc, ews-watchlist, graouts, kondapallykalyan, rniwa, webkit-bug-importer | ||||||||||||||||||||||||||||||||||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||||||||||||||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||||||||||||||||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||||||||||||||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||||||||||||||||||||||||||||||||
Attachments: |
|
Description
Myles C. Maxfield
2019-03-08 20:04:49 PST
Created attachment 364108 [details]
WIP
Created attachment 364109 [details]
Test case
Attachment 364108 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 16 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 364318 [details]
Test case
Created attachment 364338 [details]
WIP
Attachment 364338 [details] did not pass style-queue:
ERROR: Source/WTF/wtf/Expected.h:346: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4]
ERROR: Source/WTF/wtf/Expected.h:348: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4]
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 3 in 19 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 364359 [details]
Test case
Created attachment 364360 [details]
WIP
Attachment 364360 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 19 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 364414 [details]
Test case
Created attachment 364416 [details]
WIP
Attachment 364416 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 21 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 364494 [details]
WIP
Created attachment 364514 [details]
Test case
Created attachment 364520 [details]
WIP
Attachment 364520 [details] did not pass style-queue:
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:53: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:54: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:55: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:56: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:57: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:58: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:59: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:60: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:61: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:62: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:63: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:64: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:65: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:66: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:67: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:68: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:69: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:70: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:71: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:72: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:73: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:74: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:75: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:76: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:77: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:78: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:79: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:80: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:81: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:82: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:83: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:84: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:85: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:86: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:87: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:88: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:89: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:90: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:91: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:92: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:93: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:94: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:95: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:96: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLResolvingType.h:34: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 46 in 39 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 364588 [details]
WIP
Attachment 364588 [details] did not pass style-queue:
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:53: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:54: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:55: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:56: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:57: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:58: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:59: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:60: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:61: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:62: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:63: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:64: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:65: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:66: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:67: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:68: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:69: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:70: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:71: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:72: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:73: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:74: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:75: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:76: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:77: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:78: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:79: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:80: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:81: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:82: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:83: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:84: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:85: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:86: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:87: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:88: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:89: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:90: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:91: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:92: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:93: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:94: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:95: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:96: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLResolvingType.h:34: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 46 in 46 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 364588 [details] WIP Attachment 364588 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11496025 New failing tests: imported/w3c/web-platform-tests/webrtc/simplecall.https.html Created attachment 364604 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Created attachment 364614 [details]
WIP
Comment on attachment 364614 [details] WIP Attachment 364614 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11500250 New failing tests: webgpu/whlsl.html Created attachment 364631 [details]
Archive of layout-test-results from ews105 for mac-highsierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Created attachment 364638 [details]
WIP
Attachment 364638 [details] did not pass style-queue:
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPrepare.cpp:86: Should have a space between // and comment [whitespace/comments] [4]
Total errors found: 1 in 51 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 364638 [details] WIP Attachment 364638 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11501967 New failing tests: webgpu/whlsl.html Created attachment 364643 [details]
Archive of layout-test-results from ews104 for mac-highsierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Created attachment 364745 [details]
Simpler test case
Created attachment 364746 [details]
WIP
Attachment 364746 [details] did not pass style-queue:
ERROR: Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLFunctionWriter.cpp:449: Should have a space between // and comment [whitespace/comments] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLFunctionWriter.cpp:456: Should have a space between // and comment [whitespace/comments] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLFunctionWriter.cpp:462: Should have a space between // and comment [whitespace/comments] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPrepare.cpp:86: Should have a space between // and comment [whitespace/comments] [4]
Total errors found: 4 in 52 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 364755 [details]
WIP
Attachment 364755 [details] did not pass style-queue:
ERROR: Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLFunctionWriter.cpp:449: Should have a space between // and comment [whitespace/comments] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLFunctionWriter.cpp:456: Should have a space between // and comment [whitespace/comments] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLFunctionWriter.cpp:462: Should have a space between // and comment [whitespace/comments] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPrepare.cpp:86: Should have a space between // and comment [whitespace/comments] [4]
ERROR: Source/WebCore/platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm:267: Should have a space between // and comment [whitespace/comments] [4]
Total errors found: 5 in 52 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 364779 [details]
WIP
Attachment 364779 [details] did not pass style-queue:
ERROR: Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLFunctionWriter.cpp:449: Should have a space between // and comment [whitespace/comments] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLFunctionWriter.cpp:456: Should have a space between // and comment [whitespace/comments] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLFunctionWriter.cpp:462: Should have a space between // and comment [whitespace/comments] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPrepare.cpp:86: Should have a space between // and comment [whitespace/comments] [4]
ERROR: Source/WebCore/platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm:267: Should have a space between // and comment [whitespace/comments] [4]
Total errors found: 5 in 55 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 364780 [details]
WIP
Attachment 364780 [details] did not pass style-queue:
ERROR: Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLFunctionWriter.cpp:449: Should have a space between // and comment [whitespace/comments] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLFunctionWriter.cpp:456: Should have a space between // and comment [whitespace/comments] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLFunctionWriter.cpp:462: Should have a space between // and comment [whitespace/comments] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPrepare.cpp:86: Should have a space between // and comment [whitespace/comments] [4]
ERROR: Source/WebCore/platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm:267: Should have a space between // and comment [whitespace/comments] [4]
Total errors found: 5 in 56 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 364828 [details]
Patch
Comment on attachment 364828 [details] Patch Clearing flags on attachment: 364828 Committed r243091: <https://trac.webkit.org/changeset/243091> All reviewed patches have been landed. Closing bug. Committed r243105: <https://trac.webkit.org/changeset/243105> |