Bug 195507

Summary: ScrollingTree should have the final say on where layers go
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, ews-watchlist, fred.wang, jamesr, koivisto, luiz, rniwa, ryanhaddad, simon.fraser, tonikitoo, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=195584
Attachments:
Description Flags
Patch
none
Patch
koivisto: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews107 for mac-highsierra-wk2
none
Patch none

Description Simon Fraser (smfr) 2019-03-08 18:41:45 PST
ScrollingTree should have the final say on where layers go
Comment 1 Simon Fraser (smfr) 2019-03-08 18:50:53 PST
Created attachment 364107 [details]
Patch
Comment 2 Simon Fraser (smfr) 2019-03-08 20:37:14 PST
Created attachment 364110 [details]
Patch
Comment 3 EWS Watchlist 2019-03-09 16:28:19 PST
Comment on attachment 364110 [details]
Patch

Attachment 364110 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/11441789

New failing tests:
accessibility/mac/selection-notification-focus-change.html
Comment 4 EWS Watchlist 2019-03-09 16:28:21 PST
Created attachment 364145 [details]
Archive of layout-test-results from ews107 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6
Comment 5 Simon Fraser (smfr) 2019-03-10 10:09:49 PDT
Created attachment 364182 [details]
Patch
Comment 6 Simon Fraser (smfr) 2019-03-10 11:17:17 PDT
https://trac.webkit.org/changeset/242687/webkit
Comment 7 Radar WebKit Bug Importer 2019-03-10 11:18:24 PDT
<rdar://problem/48751114>
Comment 9 Ryan Haddad 2019-03-11 13:46:13 PDT
(In reply to Truitt Savell from comment #8)
> The changes in https://trac.webkit.org/changeset/242687/webkit
> 
> appears to have broken compositing/ios/overflow-scroll-update-overlap.html
> on iOS. It also looks like it is slowing down EWS
Should we go ahead and roll this out?
Comment 10 Simon Fraser (smfr) 2019-03-11 14:15:34 PDT
(In reply to Ryan Haddad from comment #9)
> (In reply to Truitt Savell from comment #8)
> > The changes in https://trac.webkit.org/changeset/242687/webkit
> > 
> > appears to have broken compositing/ios/overflow-scroll-update-overlap.html
> > on iOS. It also looks like it is slowing down EWS
> Should we go ahead and roll this out?

No, I'll look at this now.
Comment 11 Simon Fraser (smfr) 2019-03-11 17:13:27 PDT
I filed bug 195584 to fix that, and marked the test as failing in r242758.
Comment 12 Simon Fraser (smfr) 2019-03-12 20:04:27 PDT
*** Bug 194996 has been marked as a duplicate of this bug. ***