Bug 195495

Summary:

Simplify DOMWindowProperty code / handling

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

WebCore Misc.

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

beidson, commit-queue, ews-watchlist, ggaren, rniwa, ryanhaddad, tsavell, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
WIP Patch	none
Archive of layout-test-results from ews107 for mac-highsierra-wk2	none
Patch	none
Archive of layout-test-results from ews105 for mac-highsierra-wk2	none
Patch	none
Patch	none

Chris Dumez

Reported 2019-03-08 16:38:55 PST

Simplify DOMWindowProperty code / handling.

Attachments
WIP Patch (23.57 KB, patch) 2019-03-08 16:39 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews107 for mac-highsierra-wk2 (2.64 MB, application/zip) 2019-03-08 21:36 PST, EWS Watchlist	no flags	Details
Patch (34.13 KB, patch) 2019-03-09 08:52 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews105 for mac-highsierra-wk2 (2.68 MB, application/zip) 2019-03-09 10:12 PST, EWS Watchlist	no flags	Details
Patch (36.21 KB, patch) 2019-03-09 11:49 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (36.28 KB, patch) 2019-03-09 12:26 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2019-03-08 16:39:43 PST

Created attachment 364089 [details] WIP Patch

EWS Watchlist

Comment 2 2019-03-08 21:36:41 PST

Comment on attachment 364089 [details] WIP Patch Attachment 364089 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11435697 New failing tests: compositing/video/video-clip-change-src.html

EWS Watchlist

Comment 3 2019-03-08 21:36:43 PST

Created attachment 364115 [details] Archive of layout-test-results from ews107 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

Chris Dumez

Comment 4 2019-03-09 08:52:49 PST

Created attachment 364131 [details] Patch

EWS Watchlist

Comment 5 2019-03-09 10:12:49 PST

Comment on attachment 364131 [details] Patch Attachment 364131 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11439713 New failing tests: compositing/video/video-clip-change-src.html

EWS Watchlist

Comment 6 2019-03-09 10:12:50 PST

Created attachment 364133 [details] Archive of layout-test-results from ews105 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

Chris Dumez

Comment 7 2019-03-09 11:08:05 PST

(In reply to Build Bot from comment #5) > Comment on attachment 364131 [details] > Patch > > Attachment 364131 [details] did not pass mac-wk2-ews (mac-wk2): > Output: https://webkit-queues.webkit.org/results/11439713 > > New failing tests: > compositing/video/video-clip-change-src.html This is a flake, it passes locally with my patch and also fails on other bugs: https://bugs.webkit.org/show_bug.cgi?id=195475#c5

Chris Dumez

Comment 8 2019-03-09 11:49:39 PST

Created attachment 364137 [details] Patch

Chris Dumez

Comment 9 2019-03-09 12:26:24 PST

Created attachment 364138 [details] Patch

Chris Dumez

Comment 10 2019-03-09 18:25:48 PST

Comment on attachment 364138 [details] Patch Clearing flags on attachment: 364138 Committed r242676: <https://trac.webkit.org/changeset/242676>

Chris Dumez

Comment 11 2019-03-09 18:25:50 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 12 2019-03-09 18:51:29 PST

<rdar://problem/48745832>

Note You need to log in before you can comment on or make changes to this bug.