Bug 195490 – DFG::Worklist can be shrunk by 16 bytes

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Robin Morisset]

simply by reordering the fields to avoid padding.

[Robin Morisset]

Created attachment 364085 [details]
Patch

[EWS Watchlist]

Comment on attachment 364085 [details]
Patch

Attachment 364085 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/11437253

New failing tests:
accessibility/mac/selection-notification-focus-change.html

[EWS Watchlist]

Created attachment 364124 [details]
Archive of layout-test-results from ews105 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

[Darin Adler]

Comment on attachment 364085 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364085&action=review

> Source/JavaScriptCore/dfg/DFGWorklist.cpp:187
> +    : m_numberOfActiveThreads(0)

Initialize in class definition instead?

[Robin Morisset]

Comment on attachment 364085 [details]
Patch

Tons of other unrelated patches have the same test failure, so I am pretty sure it is just a flaky test.

[Robin Morisset]

Comment on attachment 364085 [details]
Patch

Missed the comment above

[Robin Morisset]

(In reply to Darin Adler from comment #4)
> Comment on attachment 364085 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=364085&action=review
> 
> > Source/JavaScriptCore/dfg/DFGWorklist.cpp:187
> > +    : m_numberOfActiveThreads(0)
> 
> Initialize in class definition instead?

The initialization includes
", m_threadName(createWorklistName(WTFMove(tierName)))", and createWorklistName is a static function that is only available within DFGWorklist.cpp.
I could move it along with the initialization code to the class definition in DFGWorklist.h. What would be the expected benefit from doing this?

[Darin Adler]

Comment on attachment 364085 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364085&action=review

>>> Source/JavaScriptCore/dfg/DFGWorklist.cpp:187
>>> +    : m_numberOfActiveThreads(0)
>> 
>> Initialize in class definition instead?
> 
> The initialization includes
> ", m_threadName(createWorklistName(WTFMove(tierName)))", and createWorklistName is a static function that is only available within DFGWorklist.cpp.
> I could move it along with the initialization code to the class definition in DFGWorklist.h. What would be the expected benefit from doing this?

Comment was only about m_numberOfActiveThreads, not the rest of the initialization.

[EWS Watchlist]

Comment on attachment 364085 [details]
Patch

Attachment 364085 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/11461947

New failing tests:
http/tests/cache/memory-cache-pruning.html

[EWS Watchlist]

Created attachment 364307 [details]
Archive of layout-test-results from ews201 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews201  Port: win-future  Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit

[Robin Morisset]

Created attachment 364401 [details]
Patch

Initialized m_numberOfActiveThreads in the class definition per Darin's suggestion.

[WebKit Commit Bot]

Comment on attachment 364401 [details]
Patch

Clearing flags on attachment: 364401

Committed r242944: <https://trac.webkit.org/changeset/242944>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/48889334>