| Summary: | [ews-app] Add support for submit-to-ews url | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aakash_jain, ap, commit-queue, dean_johnson, dewei_zhu, kocsen_chung, lforschler, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | Other | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Aakash Jain
2019-03-08 13:51:27 PST
Created attachment 364065 [details]
Proposed patch
Comment on attachment 364065 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=364065&action=review > Tools/BuildSlaveSupport/ews-app/ews/fetcher.py:53 > + def fetch(self, patch_ids=None): > + if not patch_ids: > + patch_ids = Bugzilla.get_list_of_patches_needing_reviews() We may want to check the type of patch_ids here. BugzillaPatchFetcher().fetch(1) will cause exceptions in next line. > Tools/BuildSlaveSupport/ews-app/ews/views/submittoews.py:40 > +@method_decorator(csrf_exempt, name='dispatch') Do we have a security justification for not having csrf here? Created attachment 364269 [details] Patch for landing > We may want to check the type of patch_ids here. Added the check. > Do we have a security justification for not having csrf here? Removed csrf_exempt decorator. Updated templates accordingly (by adding {% csrf_token %}) Comment on attachment 364269 [details] Patch for landing Clearing flags on attachment: 364269 Committed r242719: <https://trac.webkit.org/changeset/242719> All reviewed patches have been landed. Closing bug. |