Bug 195471

Summary:

Web Inspector: CPU Usage Timeline - Enable by default

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	hi: review+

Description Joseph Pecoraro 2019-03-08 10:49:20 PST

CPU Usage Timeline - Enable by default

- And remove Legacy

Comment 1 Joseph Pecoraro 2019-03-08 10:50:32 PST

Created attachment 364034 [details]
[PATCH] Proposed Fix

Comment 2 Devin Rousso 2019-03-08 17:56:34 PST

Comment on attachment 364034 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=364034&action=review

r=me

> Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js:113
> +        if (WI.CPUInstrument.supported())
> +            defaultTypes.push(WI.TimelineRecord.Type.CPU);

Should we put this above the FPS instrument, seeing as it's shown in the same grouping as the other default types (e.g. the rendering frame timeline is a separate "view"/"tab" from Network/Layout/Script)?

Comment 3 Joseph Pecoraro 2019-03-11 14:31:08 PDT

https://trac.webkit.org/r242741

Comment 4 Radar WebKit Bug Importer 2019-03-11 14:32:22 PDT

<rdar://problem/48782918>