| Summary: | Have the UIProcess take the UnboundedNetworking assertion when downloads are in progress | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||||||||||||
| Component: | WebKit Misc. | Assignee: | Brady Eidson <beidson> | ||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||
| Severity: | Normal | CC: | aestes, commit-queue, ews-watchlist, webkit-bug-importer | ||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
|
Description
Brady Eidson
2019-03-08 10:32:12 PST
Created attachment 364031 [details]
Patch
This patch relies on the still-unlanded patch in 195465 to land, so it won't apply on EWS... but it's small and reviewable nonetheless
Created attachment 364040 [details]
Patch
Created attachment 364045 [details]
Patch
Attachment 364045 [details] did not pass style-queue:
ERROR: Source/WebKit/UIProcess/Downloads/DownloadProxyMap.cpp:34: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 364046 [details]
Patch
Created attachment 364053 [details]
Patch
Created attachment 364061 [details]
Patch
Dammit Windows...
Comment on attachment 364061 [details] Patch Rejecting attachment 364061 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 364061, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebKit/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/11431460 Created attachment 364078 [details]
PFL
Comment on attachment 364078 [details] PFL Clearing flags on attachment: 364078 Committed r242662: <https://trac.webkit.org/changeset/242662> All reviewed patches have been landed. Closing bug. |