Summary: | [Gtk] Crasher when using file:// protocol | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jan Alonzo <jmalonzo> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED DUPLICATE | ||||||
Severity: | Normal | Keywords: | Gtk | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Jan Alonzo
2008-06-14 01:37:44 PDT
Created attachment 21699 [details]
sample html file
Steps to reproduce:
1. Launch GtkLauncher
2. Open the file using file://path/to/file
Following is a fix from Alp (http://paste.lisp.org/display/61072). If you know GIO, please let us know if the fix is correct. Index: WebCore/platform/network/soup/ResourceHandleSoup.cpp =================================================================== --- WebCore/platform/network/soup/ResourceHandleSoup.cpp (revision 33954) +++ WebCore/platform/network/soup/ResourceHandleSoup.cpp (working copy) @@ -412,9 +412,11 @@ { ResourceHandle* handle = static_cast<ResourceHandle*>(data); ResourceHandleInternal* d = handle->getInternal(); + ResourceHandleClient* client = handle->client(); g_input_stream_close_finish(d->m_input_stream, res, NULL); cleanupGioOperation(handle); + client->didFinishLoading(handle); } static void readCallback(GObject* source, GAsyncResult* res, gpointer data) @@ -438,7 +440,6 @@ client->didFinishLoading(handle); return; } else if (!nread) { - client->didFinishLoading(handle); g_input_stream_close_async(d->m_input_stream, G_PRIORITY_DEFAULT, NULL, closeCallback, handle); return; (In reply to comment #2) > Following is a fix from Alp (http://paste.lisp.org/display/61072). If you know > GIO, please let us know if the fix is correct. I think that the patch is right (I wrote an identical patch for this bug) but it's not the only fix required for the soup/gio back-end as also the patch for bug #19603 is needed. Can you mark this bug as a dup of #19603 (even if this is older) as it has the complete patch with a changelog entry? |