Bug 195449

Summary: [JSC] Make more fields lazy in JSGlobalObject
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, calvaris, ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch mark.lam: review+

Description Yusuke Suzuki 2019-03-07 19:21:37 PST
[JSC] Make more fields lazy in JSGlobalObject
Comment 1 Yusuke Suzuki 2019-03-07 19:25:19 PST
Created attachment 363974 [details]
Patch
Comment 2 Yusuke Suzuki 2019-03-07 20:05:54 PST
Comment on attachment 363974 [details]
Patch

Oops, crashing. Investigating...
Comment 3 Yusuke Suzuki 2019-03-07 20:26:04 PST
Created attachment 363979 [details]
Patch
Comment 4 Mark Lam 2019-03-07 21:14:06 PST
Comment on attachment 363979 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363979&action=review

r=me

> Source/JavaScriptCore/runtime/JSGlobalObject.cpp:317
> +  eval                  JSGlobalObject::m_evalFunction               DontEnum|CellProperty

Should you group this with the other CellPropertys below?  This list isn't in alphabetical order anyway.
Comment 5 Yusuke Suzuki 2019-03-07 21:15:09 PST
Comment on attachment 363979 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363979&action=review

>> Source/JavaScriptCore/runtime/JSGlobalObject.cpp:317
>> +  eval                  JSGlobalObject::m_evalFunction               DontEnum|CellProperty
> 
> Should you group this with the other CellPropertys below?  This list isn't in alphabetical order anyway.

OK, fixed :)
Comment 6 Yusuke Suzuki 2019-03-07 22:17:39 PST
Committed r242636: <https://trac.webkit.org/changeset/242636>
Comment 7 Radar WebKit Bug Importer 2019-03-07 22:18:24 PST
<rdar://problem/48702977>