Bug 195449

Summary: [JSC] Make more fields lazy in JSGlobalObject
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, calvaris, ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch mark.lam: review+

Yusuke Suzuki
Reported 2019-03-07 19:21:37 PST
[JSC] Make more fields lazy in JSGlobalObject
Attachments
Patch (28.61 KB, patch)
2019-03-07 19:25 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (32.90 KB, patch)
2019-03-07 20:26 PST, Yusuke Suzuki 		mark.lam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-03-07 19:25:19 PST
Created attachment 363974 [details] Patch
Yusuke Suzuki
Comment 2 2019-03-07 20:05:54 PST
Comment on attachment 363974 [details] Patch Oops, crashing. Investigating...
Yusuke Suzuki
Comment 3 2019-03-07 20:26:04 PST
Created attachment 363979 [details] Patch
Mark Lam
Comment 4 2019-03-07 21:14:06 PST
Comment on attachment 363979 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363979&action=review r=me > Source/JavaScriptCore/runtime/JSGlobalObject.cpp:317 > + eval JSGlobalObject::m_evalFunction DontEnum|CellProperty Should you group this with the other CellPropertys below? This list isn't in alphabetical order anyway.
Yusuke Suzuki
Comment 5 2019-03-07 21:15:09 PST
Comment on attachment 363979 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363979&action=review >> Source/JavaScriptCore/runtime/JSGlobalObject.cpp:317 >> + eval JSGlobalObject::m_evalFunction DontEnum|CellProperty > > Should you group this with the other CellPropertys below? This list isn't in alphabetical order anyway. OK, fixed :)
Yusuke Suzuki
Comment 6 2019-03-07 22:17:39 PST
Committed r242636: <https://trac.webkit.org/changeset/242636>
Radar WebKit Bug Importer
Comment 7 2019-03-07 22:18:24 PST
<rdar://problem/48702977>
Note You need to log in before you can comment on or make changes to this bug.