Summary: | [iOS] Pasting text into Microsoft Visio sometimes zooms and scrolls | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||
Component: | WebKit Misc. | Assignee: | Daniel Bates <dbates> | ||||
Status: | ASSIGNED --- | ||||||
Severity: | Normal | CC: | megan_gardner, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh | ||||
Priority: | P2 | Keywords: | InRadar, PlatformOnly | ||||
Version: | WebKit Local Build | ||||||
Hardware: | iPhone / iPad | ||||||
OS: | iOS 12 | ||||||
Attachments: |
|
Description
Daniel Bates
2019-03-07 14:53:51 PST
Created attachment 363934 [details]
Work-in-progress
Comment on attachment 363934 [details] Work-in-progress View in context: https://bugs.webkit.org/attachment.cgi?id=363934&action=review > Source/WebKit/WebProcess/WebPage/WebPage.cpp:5321 > + isProgrammaticRefocus = !m_userIsInteracting && m_keyboardIsAttached; I haven't considered this approach thoroughly yet, but here's a quick comment... isProgrammaticRefocus seems like a strange name for this variable. The fact that it's always false on non-iOS platforms would imply that it's not possible to programmatically refocus an element there (which is not true!) It's also unclear to me why m_keyboardIsAttached would matter here — an element can always be programmatically focused after it already has focus, regardless of whether or not a hardware keyboard is attached. The difference seems to be whether or not programmatic focus is allowed to bring up the input view. Is this really about whether or not programmatic focus causes the input view to be shown by default? Don’t let the name get to you because I don’t like it too and need to think some more about this code to figure out a) whether this approach is correct b) where the code should live (originally the whole focus due to user interaction was in WebPageIOS and and c) what the name of the variable and existing variables should be called This bug also happens on Mac when you paste or paste with matching style. Need to try with Chrome/Firefox/Edge. |