| Summary: | Delete WebMetal implementation in favor of WebGPU | ||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||||||||||||||||||||||||
| Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||||||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||||||||||
| Severity: | Normal | CC: | commit-queue, dino, ews-watchlist, hi, jonlee, justin_fan, rniwa, webkit-bug-importer | ||||||||||||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||||||
|
Description
Myles C. Maxfield
2019-03-07 10:41:53 PST
Created attachment 363896 [details]
Patch
Comment on attachment 363896 [details]
Patch
I couldn't find them, but I assume the tests in Tools are also removed.
Created attachment 363899 [details]
Patch
Created attachment 363900 [details]
Patch for committing
I will defer committing until we have compute facilities in WebGPU. Created attachment 363948 [details]
Patch for committing
Created attachment 363962 [details]
Patch for committing
Created attachment 363963 [details]
Patch for committing
Comment on attachment 363963 [details] Patch for committing Attachment 363963 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/11421479 New failing tests: inspector/canvas/resolveCanvasContext-webmetal.html fast/canvas/webmetal/webmetal-dispatch.html fast/canvas/webmetal/webmetal-runtime-flag.html Created attachment 363971 [details]
Archive of layout-test-results from ews102 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 363963 [details] Patch for committing Attachment 363963 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11421570 New failing tests: inspector/canvas/resolveCanvasContext-webmetal.html fast/canvas/webmetal/webmetal-dispatch.html fast/canvas/webmetal/webmetal-runtime-flag.html Created attachment 363973 [details]
Archive of layout-test-results from ews105 for mac-highsierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 363963 [details] Patch for committing Attachment 363963 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/11425992 New failing tests: inspector/canvas/resolveCanvasContext-webmetal.html fast/canvas/webmetal/webmetal-dispatch.html fast/canvas/webmetal/webmetal-runtime-flag.html Created attachment 364010 [details]
Archive of layout-test-results from ews114 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 364293 [details]
Patch for committing
Created attachment 365942 [details]
WIP
Created attachment 365944 [details]
Patch for committing
Created attachment 366290 [details]
Patch for committing
Comment on attachment 366290 [details] Patch for committing Clearing flags on attachment: 366290 Committed r243666: <https://trac.webkit.org/changeset/243666> Comment on attachment 366290 [details] Patch for committing View in context: https://bugs.webkit.org/attachment.cgi?id=366290&action=review > Source/WebInspectorUI/UserInterface/Models/Canvas.js:-78 > - case CanvasAgent.ContextType.WebMetal: We actually still want this to exist, so that we support older backends (just like how we "still" have WebGPU (meaning the older WebGPU, which was renamed to WebMetal)). <https://webkit.org/b/196412> |