Bug 195417

Summary:

[ContentChangeObserver] Check if max-height change triggers visible content change.

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description zalan 2019-03-07 10:37:28 PST

going from fixed max-height: 0px; to max-height: non-zero

Comment 1 Radar WebKit Bug Importer 2019-03-07 10:40:58 PST

<rdar://problem/48680631>

Comment 2 zalan 2019-03-07 10:45:24 PST

Created attachment 363897 [details]
Patch

Comment 3 Simon Fraser (smfr) 2019-03-07 11:40:43 PST

Comment on attachment 363897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363897&action=review

> Source/WebCore/page/ios/ContentChangeObserver.cpp:299
>      if (left.isFixed() && width.isFixed() && -left.value() >= width.value())

This is stupid and you should add a comment to explain how stupid it is.

> Source/WebCore/page/ios/ContentChangeObserver.cpp:305
> +    auto maxHeight = style.maxHeight();

Maybe comment to say that height + overflow:hidden should also be checked at some point.

Comment 4 zalan 2019-03-07 21:22:38 PST

Created attachment 363985 [details]
Patch

Comment 5 WebKit Commit Bot 2019-03-07 22:09:04 PST

Comment on attachment 363985 [details]
Patch

Clearing flags on attachment: 363985

Committed r242634: <https://trac.webkit.org/changeset/242634>

Comment 6 WebKit Commit Bot 2019-03-07 22:09:06 PST

All reviewed patches have been landed.  Closing bug.