Bug 195408 – [GTK] Several InputMethodFilter tests are failing

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Diego Pino]

From https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/9917/steps/API%20tests/logs/stdio:


```
**FAIL** WebKit2.InputMethodFilterSimple



/home/slave/webkitgtk/gtk-linux-64-release/build/Tools/TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:101

Expected equality of these values:

  String("sendSimpleKeyEvent type=press keycode=6b text='k'")

    Which is: sendSimpleKeyEvent type=press keycode=6b text='k'

  events[4]

    Which is: sendSimpleKeyEvent type=press keycode=6B text='k'



**FAIL** WebKit2.InputMethodFilterUnicodeSequence



/home/slave/webkitgtk/gtk-linux-64-release/build/Tools/TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:129

Expected equality of these values:

  String("sendSimpleKeyEvent type=press keycode=ffe3")

    Which is: sendSimpleKeyEvent type=press keycode=ffe3

  events[0]

    Which is: sendSimpleKeyEvent type=press keycode=FFE3



**FAIL** WebKit2.InputMethodFilterComposeKey



/home/slave/webkitgtk/gtk-linux-64-release/build/Tools/TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:162

Expected equality of these values:

  String("sendKeyEventWithCompositionResults type=press keycode=6f")

    Which is: sendKeyEventWithCompositionResults type=press keycode=6f

  events[0]

    Which is: sendKeyEventWithCompositionResults type=press keycode=6F



**FAIL** WebKit2.InputMethodFilterContextEventsWithoutKeyEvents



/home/slave/webkitgtk/gtk-linux-64-release/build/Tools/TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:192

Expected equality of these values:

  String("sendKeyEventWithCompositionResults type=press keycode=ffffff (faked)")

    Which is: sendKeyEventWithCompositionResults type=press keycode=ffffff (faked)

  events[0]

    Which is: sendKeyEventWithCompositionResults type=press keycode=FFFFFF (faked)
```

[Diego Pino]

Created attachment 363870 [details]
Patch

[EWS Watchlist]

Attachment 363870 [details] did not pass style-queue:


ERROR: Tools/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Tools/ChangeLog:10:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Diego Pino]

Created attachment 363872 [details]
Patch

[Diego Pino]

Since https://bugs.webkit.org/show_bug.cgi?id=194752 hexadecimal keycodes are returned in upper letters. That made several tests fail, since they expected an hexadecimal value in lower letters.

On the other hand, there were two tests that compared a string to the result of a composited string, which is an UTF-8 string. So the expected string should be UTF-8 too.

[Carlos Garcia Campos]

Comment on attachment 363872 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363872&action=review

Thanks!

> Tools/ChangeLog:7
> +

Please, mention in the changelog that this regressed in r241751, that helps me to know whether I have to merge this in stable branches or not.

[EWS Watchlist]

Comment on attachment 363872 [details]
Patch

Attachment 363872 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/11414025

New failing tests:
imported/w3c/web-platform-tests/webrtc/simplecall-no-ssrcs.https.html

[EWS Watchlist]

Created attachment 363876 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[Diego Pino]

Created attachment 363880 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 363880 [details]
Patch

Clearing flags on attachment: 363880

Committed r242638: <https://trac.webkit.org/changeset/242638>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.