Bug 195399

Summary: [WinCairo][WebKit] Nothing is drawn after Web process crashed
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: WebKit2Assignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, andersca, bfulgham, don.olmstead, rniwa, ross.kirsling, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Fujii Hironori 2019-03-06 23:04:08 PST 
[WinCairo][WebKit] Nothing is drawn after Web process crashed

1. Start MiniBrowser (default mode is modern WebKit WebView Window)
2. Go to https://webkit.org
3. Kill WebKitWebProcess.exe by using Windows Task Manager
4. Go to https://webkit.org
5. Nothing is drawn
Comment 1 Fujii Hironori 2019-03-06 23:06:02 PST 
PageClientImpl::viewSize returns 0x0 size after Web process crashed.
The original implementation (Bug 52175) was using GetClientRect.
Comment 2 Fujii Hironori 2019-03-06 23:12:53 PST 
Created attachment 363849 [details]
Patch
Comment 3 Alex Christensen 2019-03-07 09:24:43 PST 
Comment on attachment 363849 [details]
Patch

r=me
build failure looks suspicious.
Comment 4 Don Olmstead 2019-03-07 09:29:34 PST 
(In reply to Alex Christensen from comment #3)
> Comment on attachment 363849 [details]
> Patch
> 
> r=me
> build failure looks suspicious.

WinCairo has been broken since r242596 and the compile output looks the same here. I think this is safe to cq+ since the build output is unrelated.
Comment 5 Fujii Hironori 2019-03-07 17:35:49 PST 
Comment on attachment 363849 [details]
Patch

Clearing flags on attachment: 363849

Committed r242625: <https://trac.webkit.org/changeset/242625>
Comment 6 Fujii Hironori 2019-03-07 17:35:52 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-03-07 17:42:05 PST 
<rdar://problem/48697852>