Bug 195394 – Clean up / simplify ProcessAssertion code

• Component: WebKit2
• Status: RESOLVED FIXED

[Chris Dumez]

Clean up / simplify ProcessAssertion code.

[Chris Dumez]

Created attachment 363837 [details]
Patch

[Geoffrey Garen]

Comment on attachment 363837 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 363837 [details]
Patch

Rejecting attachment 363837 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 363837, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=363837&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=195394&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 363837 from bug 195394.
Fetching: https://bugs.webkit.org/attachment.cgi?id=363837
Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Source/WebKit/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/Source/WebKit/ChangeLog' is out of date
W: 329bbcd60e0b5bd13ada674f3d7e1405fb435425 and refs/remotes/origin/master differ, using rebase:
:040000 040000 8048f6dcbafb4f187ad69147012b2a47660a3fd8 f231c62f2ccb6473e48a9d7e23d312a72e955c87 M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Source/WebKit/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/Source/WebKit/ChangeLog' is out of date
W: 329bbcd60e0b5bd13ada674f3d7e1405fb435425 and refs/remotes/origin/master differ, using rebase:
:040000 040000 8048f6dcbafb4f187ad69147012b2a47660a3fd8 f231c62f2ccb6473e48a9d7e23d312a72e955c87 M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
From https://git.webkit.org/git/WebKit
   dd5e8e5ce73..c613a534e40  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 242606 = dd5e8e5ce73c1de6831a54208c04dbb30031d153
r242608 = c613a534e40f1d06cfb53aa98ea0d007df88490e
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: https://webkit-queues.webkit.org/results/11418175

[Chris Dumez]

Comment on attachment 363837 [details]
Patch

Clearing flags on attachment: 363837

Committed r242610: <https://trac.webkit.org/changeset/242610>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/48688940>