Bug 195387

Summary: [iOS] Fix sandbox violation
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=195376
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
bfulgham: review+
Patch none

Description Per Arne Vollan 2019-03-06 16:51:12 PST
The sandbox on iOS needs to allow mach lookup to the “com.apple.nesessionmanager.content-filter” mach service.
Comment 1 Per Arne Vollan 2019-03-06 16:51:36 PST
rdar://problem/48442387
Comment 2 Per Arne Vollan 2019-03-06 16:54:05 PST
Created attachment 363816 [details]
Patch
Comment 3 Brent Fulgham 2019-03-06 16:54:55 PST
Comment on attachment 363816 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363816&action=review

> Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:124
> +    (global-name "com.apple.nesessionmanager.content-filterâ) ;; <rdar://problem/48442387>

Bad quote!
Comment 4 Per Arne Vollan 2019-03-06 16:59:39 PST
Created attachment 363818 [details]
Patch
Comment 5 Per Arne Vollan 2019-03-06 17:01:51 PST
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 363816 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=363816&action=review
> 
> > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:124
> > +    (global-name "com.apple.nesessionmanager.content-filterâ) ;; <rdar://problem/48442387>
> 
> Bad quote!

Good catch! I have updated the patch. Thanks for reviewing :)
Comment 6 Per Arne Vollan 2019-03-06 17:02:50 PST
Created attachment 363819 [details]
Patch
Comment 7 Brent Fulgham 2019-03-06 17:04:46 PST
Comment on attachment 363819 [details]
Patch

r=me
Comment 8 Per Arne Vollan 2019-03-15 13:44:18 PDT
Created attachment 364834 [details]
Patch
Comment 9 Brent Fulgham 2019-03-15 13:44:57 PDT
Comment on attachment 364834 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364834&action=review

r=me

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:681
> +    (global-name "com.apple.nesessionmanager.content-filter"))

No radar here?
Comment 10 Per Arne Vollan 2019-03-15 13:51:27 PDT
Created attachment 364835 [details]
Patch
Comment 11 Per Arne Vollan 2019-03-15 13:52:30 PDT
(In reply to Brent Fulgham from comment #9)
> Comment on attachment 364834 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=364834&action=review
> 
> r=me
> 
> > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:681
> > +    (global-name "com.apple.nesessionmanager.content-filter"))
> 
> No radar here?

I have updated the patch, thanks for reviewing!
Comment 12 WebKit Commit Bot 2019-03-15 14:30:19 PDT
Comment on attachment 364835 [details]
Patch

Clearing flags on attachment: 364835

Committed r243010: <https://trac.webkit.org/changeset/243010>