[ iOS Simulator ] REGRESSION (r237702) Layout Test http/tests/security/xss-DENIED-script-inject-into-inactive-window.html is a flaky failure

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Shawn Roberts]

The following layout test is failing on iOS Simulator

http/tests/security/xss-DENIED-script-inject-into-inactive-window.html

Probable cause:

Test has been a flaky failure since it was changed in r237702. Fails 100% of the time with any previous build.

Reproduced with:

run-webkit-tests http/tests/security/xss-DENIED-script-inject-into-inactive-window.html --iterations 100 -f --ios-simulator --child-processes 4

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fsecurity%2Fxss-DENIED-script-inject-into-inactive-window.html

Diff:

--- /Volumes/Data/slave/ios-simulator-12-release-tests-wk2/build/layout-test-results/http/tests/security/xss-DENIED-script-inject-into-inactive-window-expected.txt
+++ /Volumes/Data/slave/ios-simulator-12-release-tests-wk2/build/layout-test-results/http/tests/security/xss-DENIED-script-inject-into-inactive-window-actual.txt
@@ -1,3 +1,4 @@
+ALERT: XSS
 Check the child window. The test FAILED if you see a JavaScript alert() dialog. Otherwise, it PASSED.

[Radar WebKit Bug Importer]

<rdar://problem/48657425>

[Shawn Roberts]

Additional repro information:

Found test was a flaky failure on dashboard through its available history on iOS Simulator.

Searched on Trac and found test was modified in r237702 and used this as a bisecting point.

Re-tested without extra child processes using command : run-webkit-tests http/tests/security/xss-DENIED-script-inject-into-inactive-window.html --iterations 500 -f --ios-simulator --exit-after-n-failures=5 --no-retry-failures

242568 5 out of 234 failed unexpectedly (text diff)
237702 3 out of 500 failed unexpectedly (text diff)
237701 Changed test parameters to --exit-after-n-failures=25, 25 out of 25 Unexpected timeouts (1) [ Timeout ]

[Chris Dumez]

Created attachment 366090 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 366090 [details]
Patch

Clearing flags on attachment: 366090

Committed r243558: <https://trac.webkit.org/changeset/243558>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.