Summary: | [macOS] Sandbox call violation causes WebContent process to crash | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Per Arne Vollan <pvollan> | ||||||
Component: | WebKit Misc. | Assignee: | Per Arne Vollan <pvollan> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, commit-queue, webkit-bug-importer, ysuzuki | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Per Arne Vollan
2019-03-06 14:29:26 PST
Created attachment 363794 [details]
Patch
Comment on attachment 363794 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363794&action=review > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:972 > + (syscall-number SYS_memorystatus_control) I suggest you add a comment with the Radar#, or perhaps the reason we need to include this (e.g., list which Framework uses it.) I this case, I think it night be: "..._control) ;; Needed for memory measurement infrastructure" Or something like that. Created attachment 363795 [details]
Patch
(In reply to Brent Fulgham from comment #3) > Comment on attachment 363794 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=363794&action=review > > > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:972 > > + (syscall-number SYS_memorystatus_control) > > I suggest you add a comment with the Radar#, or perhaps the reason we need > to include this (e.g., list which Framework uses it.) > > I this case, I think it night be: > > "..._control) ;; Needed for memory measurement infrastructure" > > Or something like that. Thanks for reviewing! I have updated the patch. Comment on attachment 363795 [details] Patch Clearing flags on attachment: 363795 Committed r242570: <https://trac.webkit.org/changeset/242570> |