Bug 195379 – [macOS] Sandbox call violation causes WebContent process to crash

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Per Arne Vollan]

A new call needs to be added to the allow list in the WebContent process' sandbox.

[Per Arne Vollan]

rdar://problem/48647263

[Per Arne Vollan]

Created attachment 363794 [details]
Patch

[Brent Fulgham]

Comment on attachment 363794 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363794&action=review

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:972
> +        (syscall-number SYS_memorystatus_control)

I suggest you add a comment with the Radar#, or perhaps the reason we need to include this (e.g., list which Framework uses it.)

I this case, I think it night be:

"..._control) ;; Needed for memory measurement infrastructure"

Or something like that.

[Per Arne Vollan]

Created attachment 363795 [details]
Patch

[Per Arne Vollan]

(In reply to Brent Fulgham from comment #3)
> Comment on attachment 363794 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=363794&action=review
> 
> > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:972
> > +        (syscall-number SYS_memorystatus_control)
> 
> I suggest you add a comment with the Radar#, or perhaps the reason we need
> to include this (e.g., list which Framework uses it.)
> 
> I this case, I think it night be:
> 
> "..._control) ;; Needed for memory measurement infrastructure"
> 
> Or something like that.

Thanks for reviewing! I have updated the patch.

[WebKit Commit Bot]

Comment on attachment 363795 [details]
Patch

Clearing flags on attachment: 363795

Committed r242570: <https://trac.webkit.org/changeset/242570>