Bug 195377

Summary:

Web Inspector: DOM Debugger: event breakpoints still fire when breakpoints are disabled

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, mattbaker, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none
Archive of layout-test-results from ews101 for mac-highsierra	none
Archive of layout-test-results from ews125 for ios-simulator-wk2	none
Patch	none

Description Devin Rousso 2019-03-06 14:04:22 PST

# STEPS TO REPRODUCE:
1. open inspector2
2. set an event breakpoint on "click"
3. click on an element in the Elements tab
 => "scroll" breakpoint hit (expected)
4. disable breakpoints
5. continue
 => "scroll" breakpoint hit (unexpected)

Comment 1 Radar WebKit Bug Importer 2019-03-06 14:04:40 PST

<rdar://problem/48651645>

Comment 2 Devin Rousso 2019-03-06 15:06:28 PST

Created attachment 363797 [details]
Patch

Comment 3 Joseph Pecoraro 2019-03-06 15:09:39 PST

Comment on attachment 363797 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363797&action=review

r=me, nice!

> LayoutTests/inspector/dom-debugger/event-listener-breakpoints-expected.txt:94
> +PASS: Should only pause once.

Maybe "Should only have paused once."

Comment 4 Matt Baker 2019-03-06 15:10:35 PST

Comment on attachment 363797 [details]
Patch

r=me

Comment 5 Matt Baker 2019-03-06 15:10:54 PST

Oops. r=Joe :)

Comment 6 Devin Rousso 2019-03-06 15:17:39 PST

Created attachment 363799 [details]
Patch

Comment 7 EWS Watchlist 2019-03-06 16:19:41 PST Comment hidden (obsolete)

Comment on attachment 363799 [details]
Patch

Attachment 363799 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/11403723

New failing tests:
inspector/dom-debugger/event-listener-breakpoints.html

Comment 8 EWS Watchlist 2019-03-06 16:19:43 PST Comment hidden (obsolete)

Created attachment 363810 [details]
Archive of layout-test-results from ews101 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-highsierra  Platform: Mac OS X 10.13.6

Comment 9 EWS Watchlist 2019-03-06 17:03:09 PST Comment hidden (obsolete)

Comment on attachment 363799 [details]
Patch

Attachment 363799 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/11403796

New failing tests:
fast/viewport/ios/device-width-viewport-after-changing-view-scale.html

Comment 10 EWS Watchlist 2019-03-06 17:03:11 PST Comment hidden (obsolete)

Created attachment 363820 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

Comment 11 Devin Rousso 2019-03-06 17:20:27 PST

Created attachment 363823 [details]
Patch

Fix test structure/order for WK1.

Comment 12 WebKit Commit Bot 2019-03-06 19:21:25 PST

Comment on attachment 363823 [details]
Patch

Clearing flags on attachment: 363823

Committed r242588: <https://trac.webkit.org/changeset/242588>

Comment 13 WebKit Commit Bot 2019-03-06 19:21:26 PST

All reviewed patches have been landed.  Closing bug.