| Summary: | Make sure our .sb files are adjusted to look in /Library/Apple | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Richard Houle <rhoule> | ||||||||
| Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED INVALID | ||||||||||
| Severity: | Normal | CC: | ap, bfulgham, ews-watchlist, jberlin, jeffm, krollin, mitz, rhoule | ||||||||
| Priority: | P2 | ||||||||||
| Version: | Safari 12 | ||||||||||
| Hardware: | Mac | ||||||||||
| OS: | macOS 10.14 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Richard Houle
2019-03-06 11:06:12 PST
Created attachment 363761 [details]
Version 1
Comment on attachment 363761 [details] Version 1 Attachment 363761 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/11400538 New failing tests: js/dom/custom-constructors.html Created attachment 363778 [details]
Archive of layout-test-results from ews202 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
Windows build failure are unrelated. Comment on attachment 363761 [details]
Version 1
Isn't this change needed for the Network and Plugin Process, too?
(In reply to Brent Fulgham from comment #5) > Comment on attachment 363761 [details] > Version 1 > > Isn't this change needed for the Network and Plugin Process, too? It is only required because of the Injected Bundle. (In reply to Richard Houle from comment #6) > (In reply to Brent Fulgham from comment #5) > > Comment on attachment 363761 [details] > > Version 1 > > > > Isn't this change needed for the Network and Plugin Process, too? > > It is only required because of the Injected Bundle. Why can’t whoever specifies the injected bundle also use the _WKProcessPoolConfiguration property additionalReadAccessAllowedURLs instead of making this global change at the WebKit level? (In reply to mitz from comment #7) > (In reply to Richard Houle from comment #6) > > (In reply to Brent Fulgham from comment #5) > > > Comment on attachment 363761 [details] > > > Version 1 > > > > > > Isn't this change needed for the Network and Plugin Process, too? > > > > It is only required because of the Injected Bundle. > > Why can’t whoever specifies the injected bundle also use the > _WKProcessPoolConfiguration property additionalReadAccessAllowedURLs instead > of making this global change at the WebKit level? Good point. That would be preferable to allowing any WebKit client to have access to this directory. Richard: Can you try the approach where the UIProcess for this special case uses _WKProcessPoolConfiguration as mitz suggests? (In reply to mitz from comment #7) > (In reply to Richard Houle from comment #6) > > (In reply to Brent Fulgham from comment #5) > > > Comment on attachment 363761 [details] > > > Version 1 > > > > > > Isn't this change needed for the Network and Plugin Process, too? > > > > It is only required because of the Injected Bundle. > > Why can’t whoever specifies the injected bundle also use the > _WKProcessPoolConfiguration property additionalReadAccessAllowedURLs instead > of making this global change at the WebKit level? Good suggestion. I still need to submit a WebKit level change. Mac Safari still goes through the C-API (rather than _WKProcessPoolConfiguration.) Created attachment 363956 [details]
Version 2
(In reply to Richard Houle from comment #9) > (In reply to mitz from comment #7) > > (In reply to Richard Houle from comment #6) > > > (In reply to Brent Fulgham from comment #5) > > > > Comment on attachment 363761 [details] > > > > Version 1 > > > > > > > > Isn't this change needed for the Network and Plugin Process, too? > > > > > > It is only required because of the Injected Bundle. > > > > Why can’t whoever specifies the injected bundle also use the > > _WKProcessPoolConfiguration property additionalReadAccessAllowedURLs instead > > of making this global change at the WebKit level? > > Good suggestion. > > I still need to submit a WebKit level change. Mac Safari still goes through > the C-API (rather than _WKProcessPoolConfiguration.) WKContextConfigurationRef is toll-free bridged to _WKProcessPoolConfiguration. There’s no need to add C API, because clients can cast and use the Objective-C API. (In reply to mitz from comment #11) > (In reply to Richard Houle from comment #9) > > (In reply to mitz from comment #7) > > > (In reply to Richard Houle from comment #6) > > > > (In reply to Brent Fulgham from comment #5) > > > > > Comment on attachment 363761 [details] > > > > > Version 1 > > > > > > > > > > Isn't this change needed for the Network and Plugin Process, too? > > > > > > > > It is only required because of the Injected Bundle. > > > > > > Why can’t whoever specifies the injected bundle also use the > > > _WKProcessPoolConfiguration property additionalReadAccessAllowedURLs instead > > > of making this global change at the WebKit level? > > > > Good suggestion. > > > > I still need to submit a WebKit level change. Mac Safari still goes through > > the C-API (rather than _WKProcessPoolConfiguration.) > > WKContextConfigurationRef is toll-free bridged to > _WKProcessPoolConfiguration. There’s no need to add C API, because clients > can cast and use the Objective-C API. Thanks for pointing it out. It was not obvious my looking at the source code. |