Bug 195366 – Make sure our .sb files are adjusted to look in /Library/Apple

• Component: Platform
• Status: RESOLVED INVALID

[Richard Houle]

<rdar://problem/47749116> Make sure our .sb files are adjusted to look in /Library/Apple

[Richard Houle]

Created attachment 363761 [details]
Version 1

[EWS Watchlist]

Comment on attachment 363761 [details]
Version 1

Attachment 363761 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/11400538

New failing tests:
js/dom/custom-constructors.html

[EWS Watchlist]

Created attachment 363778 [details]
Archive of layout-test-results from ews202 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202  Port: win-future  Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit

[Richard Houle]

Windows build failure are unrelated.

[Brent Fulgham]

Comment on attachment 363761 [details]
Version 1

Isn't this change needed for the Network and Plugin Process, too?

[Richard Houle]

(In reply to Brent Fulgham from comment #5)
> Comment on attachment 363761 [details]
> Version 1
> 
> Isn't this change needed for the Network and Plugin Process, too?

It is only required because of the Injected Bundle.

(In reply to Richard Houle from comment #6)
> (In reply to Brent Fulgham from comment #5)
> > Comment on attachment 363761 [details]
> > Version 1
> > 
> > Isn't this change needed for the Network and Plugin Process, too?
> 
> It is only required because of the Injected Bundle.

Why can’t whoever specifies the injected bundle also use the _WKProcessPoolConfiguration property additionalReadAccessAllowedURLs instead of making this global change at the WebKit level?

[Brent Fulgham]

(In reply to mitz from comment #7)
> (In reply to Richard Houle from comment #6)
> > (In reply to Brent Fulgham from comment #5)
> > > Comment on attachment 363761 [details]
> > > Version 1
> > > 
> > > Isn't this change needed for the Network and Plugin Process, too?
> > 
> > It is only required because of the Injected Bundle.
> 
> Why can’t whoever specifies the injected bundle also use the
> _WKProcessPoolConfiguration property additionalReadAccessAllowedURLs instead
> of making this global change at the WebKit level?

Good point. That would be preferable to allowing any WebKit client to have access to this directory.

Richard: Can you try the approach where the UIProcess for this special case uses _WKProcessPoolConfiguration as mitz suggests?

[Richard Houle]

(In reply to mitz from comment #7)
> (In reply to Richard Houle from comment #6)
> > (In reply to Brent Fulgham from comment #5)
> > > Comment on attachment 363761 [details]
> > > Version 1
> > > 
> > > Isn't this change needed for the Network and Plugin Process, too?
> > 
> > It is only required because of the Injected Bundle.
> 
> Why can’t whoever specifies the injected bundle also use the
> _WKProcessPoolConfiguration property additionalReadAccessAllowedURLs instead
> of making this global change at the WebKit level?

Good suggestion.

I still need to submit a WebKit level change. Mac Safari still goes through the C-API (rather than _WKProcessPoolConfiguration.)

[Richard Houle]

Created attachment 363956 [details]
Version 2

(In reply to Richard Houle from comment #9)
> (In reply to mitz from comment #7)
> > (In reply to Richard Houle from comment #6)
> > > (In reply to Brent Fulgham from comment #5)
> > > > Comment on attachment 363761 [details]
> > > > Version 1
> > > > 
> > > > Isn't this change needed for the Network and Plugin Process, too?
> > > 
> > > It is only required because of the Injected Bundle.
> > 
> > Why can’t whoever specifies the injected bundle also use the
> > _WKProcessPoolConfiguration property additionalReadAccessAllowedURLs instead
> > of making this global change at the WebKit level?
> 
> Good suggestion.
> 
> I still need to submit a WebKit level change. Mac Safari still goes through
> the C-API (rather than _WKProcessPoolConfiguration.)

WKContextConfigurationRef is toll-free bridged to _WKProcessPoolConfiguration. There’s no need to add C API, because clients can cast and use the Objective-C API.

[Richard Houle]

(In reply to mitz from comment #11)
> (In reply to Richard Houle from comment #9)
> > (In reply to mitz from comment #7)
> > > (In reply to Richard Houle from comment #6)
> > > > (In reply to Brent Fulgham from comment #5)
> > > > > Comment on attachment 363761 [details]
> > > > > Version 1
> > > > > 
> > > > > Isn't this change needed for the Network and Plugin Process, too?
> > > > 
> > > > It is only required because of the Injected Bundle.
> > > 
> > > Why can’t whoever specifies the injected bundle also use the
> > > _WKProcessPoolConfiguration property additionalReadAccessAllowedURLs instead
> > > of making this global change at the WebKit level?
> > 
> > Good suggestion.
> > 
> > I still need to submit a WebKit level change. Mac Safari still goes through
> > the C-API (rather than _WKProcessPoolConfiguration.)
> 
> WKContextConfigurationRef is toll-free bridged to
> _WKProcessPoolConfiguration. There’s no need to add C API, because clients
> can cast and use the Objective-C API.

Thanks for pointing it out. It was not obvious my looking at the source code.