Bug 195349

Summary:

[Apple Pay] Untangle PKPaymentAuthorizationViewController from WebPaymentCoordinatorProxy

Product:

WebKit

Reporter:

Andy Estes <aestes>

Component:

New Bugs

Assignee:

Andy Estes <aestes>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, andersca, beidson, commit-queue, darin, ews-watchlist, koivisto, sam, thorton, webkit-bug-importer, wenson_hsieh, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

195078

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Description Andy Estes 2019-03-05 18:58:53 PST

[Apple Pay] Untangle PKPaymentAuthorizationViewController from WebPaymentCoordinatorProxy

Comment 1 Andy Estes 2019-03-05 19:03:03 PST Comment hidden (obsolete)

Created attachment 363720 [details]
Patch

Comment 2 Andy Estes 2019-03-05 19:33:25 PST Comment hidden (obsolete)

Created attachment 363723 [details]
Patch

Comment 3 Radar WebKit Bug Importer 2019-03-05 19:34:19 PST

<rdar://problem/48625510>

Comment 4 EWS Watchlist 2019-03-05 19:35:31 PST Comment hidden (obsolete)

Attachment 363723 [details] did not pass style-queue:


ERROR: Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h:183:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 1 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 5 Andy Estes 2019-03-05 20:04:09 PST Comment hidden (obsolete)

Created attachment 363724 [details]
Patch

Comment 6 EWS Watchlist 2019-03-05 20:06:51 PST Comment hidden (obsolete)

Attachment 363724 [details] did not pass style-queue:


ERROR: Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h:183:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 1 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 7 Andy Estes 2019-03-06 15:34:12 PST Comment hidden (obsolete)

Created attachment 363802 [details]
Patch

Comment 8 EWS Watchlist 2019-03-06 15:36:17 PST Comment hidden (obsolete)

Attachment 363802 [details] did not pass style-queue:


ERROR: Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h:183:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 1 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 9 Andy Estes 2019-03-06 16:02:28 PST Comment hidden (obsolete)

Created attachment 363805 [details]
Patch

Comment 10 EWS Watchlist 2019-03-06 16:05:45 PST Comment hidden (obsolete)

Attachment 363805 [details] did not pass style-queue:


ERROR: Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h:183:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 1 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 11 Andy Estes 2019-03-06 16:16:55 PST

Created attachment 363808 [details]
Patch

Comment 12 EWS Watchlist 2019-03-06 16:22:20 PST Comment hidden (obsolete)

Attachment 363808 [details] did not pass style-queue:


ERROR: Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h:183:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 1 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 13 Alex Christensen 2019-03-07 11:24:31 PST

Comment on attachment 363808 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363808&action=review

> Source/WebKit/Platform/cocoa/PaymentAuthorizationViewController.h:49
> +#if PLATFORM(IOS_FAMILY)
> +    PaymentAuthorizationViewController(PaymentAuthorizationPresenter::Client&, PKPaymentRequest *);
> +#endif
> +#if PLATFORM(MAC)
> +    PaymentAuthorizationViewController(PaymentAuthorizationPresenter::Client&, PKPaymentRequest *, PKPaymentAuthorizationViewController *);
> +#endif

This could be a default parameter.

Comment 14 Andy Estes 2019-03-07 11:32:37 PST Comment hidden (obsolete)

Created attachment 363904 [details]
Patch

Comment 15 EWS Watchlist 2019-03-07 11:34:44 PST Comment hidden (obsolete)

Attachment 363904 [details] did not pass style-queue:


ERROR: Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h:183:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 1 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 16 Andy Estes 2019-03-07 13:56:54 PST

Created attachment 363923 [details]
Patch

Comment 17 EWS Watchlist 2019-03-07 13:59:40 PST

Attachment 363923 [details] did not pass style-queue:


ERROR: Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h:183:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 1 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 18 WebKit Commit Bot 2019-03-07 15:30:48 PST

Comment on attachment 363923 [details]
Patch

Clearing flags on attachment: 363923

Committed r242616: <https://trac.webkit.org/changeset/242616>

Comment 19 WebKit Commit Bot 2019-03-07 15:30:50 PST

All reviewed patches have been landed.  Closing bug.