| Summary: | Fix WKPasswordView compilation on iOS | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dean Jackson <dino> | ||||||
| Component: | New Bugs | Assignee: | Dean Jackson <dino> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aestes, benjamin, cdumez, cmarcelo, dbates, ews-watchlist | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Dean Jackson
2019-03-05 15:32:30 PST
Created attachment 363708 [details]
Patch
Created attachment 363710 [details]
Patch
Comment on attachment 363710 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363710&action=review > Source/WebKit/UIProcess/ios/WKPasswordView.mm:110 > [_scrollView setBackgroundColor:[UIColor groupTableViewBackgroundColor]]; Ok as is, but if you want to be a nice guy you could fix up this line up for all Apple Engineers (including me!). Search radars on Andy Estes whose title contains groupTableView.... or poke Andy with a stick (I tried but it wasn’t sharp enough ;)) Comment on attachment 363710 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363710&action=review >> Source/WebKit/UIProcess/ios/WKPasswordView.mm:110 >> [_scrollView setBackgroundColor:[UIColor groupTableViewBackgroundColor]]; > > Ok as is, but if you want to be a nice guy you could fix up this line up for all Apple Engineers (including me!). Search radars on Andy Estes whose title contains groupTableView.... or poke Andy with a stick (I tried but it wasn’t sharp enough ;)) Actually, depending on when SYSTEM COLORS is enabled you may have worked around the issue I am referring too at least for this callsite.... still applicable To othe call sites. Digital poking (CC) Andy Committed r242552: <https://trac.webkit.org/changeset/242552> |