Web Inspector: CSS: there should be a way to inline-replace a variable with it's value

• Component: Web Inspector
• Status: RESOLVED FIXED

[Devin Rousso]

This would be useful to see/edit a specific value, rather than having to go and find and edit the variable itself.

[Devin Rousso]

Created attachment 363688 [details]
Patch

[Nikita Vasilyev]

Comment on attachment 363688 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363688&action=review

> Source/WebInspectorUI/UserInterface/Views/SpreadsheetTextField.js:199
> +        if (event.target.closest("." + WI.InlineSwatch.className))
> +            return;

I don't think SpreadsheetTextField should know about WI.InlineSwatch.
Can we call `event.stopPropagation()` in WI.InlineSwatch.prototype._swatchElementClicked?

[Joseph Pecoraro]

Comment on attachment 363688 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363688&action=review

r=me.

The Shift+Click is hard to discover, even with a tooltip, but this is quite good for now.

>> Source/WebInspectorUI/UserInterface/Views/SpreadsheetTextField.js:199
>> +            return;
> 
> I don't think SpreadsheetTextField should know about WI.InlineSwatch.
> Can we call `event.stopPropagation()` in WI.InlineSwatch.prototype._swatchElementClicked?

I like this idea as well, it makes sense for the InlineSwatch to consume the click.

[Devin Rousso]

Created attachment 363893 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 363893 [details]
Patch

Clearing flags on attachment: 363893

Committed r242602: <https://trac.webkit.org/changeset/242602>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/48682509>