Bug 195335

Summary: Web Inspector: CSS: there should be a way to inline-replace a variable with it's value
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, joepeck, nvasilyev, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Devin Rousso
Reported 2019-03-05 12:05:04 PST
This would be useful to see/edit a specific value, rather than having to go and find and edit the variable itself.
Attachments
Patch (14.94 KB, patch)
2019-03-05 14:25 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (15.60 KB, patch)
2019-03-07 10:38 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2019-03-05 14:25:45 PST
Created attachment 363688 [details] Patch
Nikita Vasilyev
Comment 2 2019-03-05 14:35:40 PST
Comment on attachment 363688 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363688&action=review > Source/WebInspectorUI/UserInterface/Views/SpreadsheetTextField.js:199 > + if (event.target.closest("." + WI.InlineSwatch.className)) > + return; I don't think SpreadsheetTextField should know about WI.InlineSwatch. Can we call `event.stopPropagation()` in WI.InlineSwatch.prototype._swatchElementClicked?
Joseph Pecoraro
Comment 3 2019-03-06 20:48:08 PST
Comment on attachment 363688 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363688&action=review r=me. The Shift+Click is hard to discover, even with a tooltip, but this is quite good for now. >> Source/WebInspectorUI/UserInterface/Views/SpreadsheetTextField.js:199 >> + return; > > I don't think SpreadsheetTextField should know about WI.InlineSwatch. > Can we call `event.stopPropagation()` in WI.InlineSwatch.prototype._swatchElementClicked? I like this idea as well, it makes sense for the InlineSwatch to consume the click.
Devin Rousso
Comment 4 2019-03-07 10:38:39 PST
Created attachment 363893 [details] Patch
WebKit Commit Bot
Comment 5 2019-03-07 11:11:58 PST
Comment on attachment 363893 [details] Patch Clearing flags on attachment: 363893 Committed r242602: <https://trac.webkit.org/changeset/242602>
WebKit Commit Bot
Comment 6 2019-03-07 11:11:59 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-03-07 11:12:26 PST
<rdar://problem/48682509>
Note You need to log in before you can comment on or make changes to this bug.