Bug 195324

Summary:

Web Inspector: Canvas: remove event listeners once a recording is ready

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, mattbaker, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

173807

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews124 for ios-simulator-wk2	none
Patch	none

Devin Rousso

Reported 2019-03-05 02:49:09 PST

Attachments
Patch (7.66 KB, patch) 2019-03-05 02:52 PST, Devin Rousso	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (10.85 MB, application/zip) 2019-03-05 04:55 PST, EWS Watchlist	no flags	Details
Patch (7.61 KB, patch) 2019-03-05 13:27 PST, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Devin Rousso

Comment 1 2019-03-05 02:52:14 PST

Created attachment 363626 [details] Patch

EWS Watchlist

Comment 2 2019-03-05 04:55:35 PST Comment hidden (obsolete)

Comment on attachment 363626 [details] Patch Attachment 363626 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11376383 New failing tests: editing/selection/thai-word-at-document-end.html

EWS Watchlist

Comment 3 2019-03-05 04:55:37 PST Comment hidden (obsolete)

Created attachment 363636 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

Matt Baker

Comment 4 2019-03-05 10:58:28 PST

Comment on attachment 363626 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363626&action=review r=me > Source/WebInspectorUI/UserInterface/Models/Recording.js:536 > + this._swizzle = null; Style: this can go after this._processing = false. I don't think it's necessary to separate these by group.

Devin Rousso

Comment 5 2019-03-05 13:27:20 PST

Created attachment 363682 [details] Patch

WebKit Commit Bot

Comment 6 2019-03-05 14:05:21 PST

Comment on attachment 363682 [details] Patch Clearing flags on attachment: 363682 Committed r242511: <https://trac.webkit.org/changeset/242511>

WebKit Commit Bot

Comment 7 2019-03-05 14:05:23 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 8 2019-03-05 14:06:25 PST

<rdar://problem/48613617>

Note You need to log in before you can comment on or make changes to this bug.