| Summary: | Web Inspector: Canvas: remove event listeners once a recording is ready | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||||
| Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, mattbaker, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 173807 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Devin Rousso
2019-03-05 02:49:09 PST
Created attachment 363626 [details]
Patch
Comment on attachment 363626 [details] Patch Attachment 363626 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11376383 New failing tests: editing/selection/thai-word-at-document-end.html Created attachment 363636 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 363626 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363626&action=review r=me > Source/WebInspectorUI/UserInterface/Models/Recording.js:536 > + this._swizzle = null; Style: this can go after this._processing = false. I don't think it's necessary to separate these by group. Created attachment 363682 [details]
Patch
Comment on attachment 363682 [details] Patch Clearing flags on attachment: 363682 Committed r242511: <https://trac.webkit.org/changeset/242511> All reviewed patches have been landed. Closing bug. |