Bug 195324

Summary: Web Inspector: Canvas: remove event listeners once a recording is ready
Product: WebKit Reporter: Devin Rousso <drousso>
Component: Web InspectorAssignee: Devin Rousso <drousso>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, drousso, ews-watchlist, inspector-bugzilla-changes, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 173807    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews124 for ios-simulator-wk2
none
Patch none

Description Devin Rousso 2019-03-05 02:49:09 PST
.
Comment 1 Devin Rousso 2019-03-05 02:52:14 PST
Created attachment 363626 [details]
Patch
Comment 2 EWS Watchlist 2019-03-05 04:55:35 PST Comment hidden (obsolete)
Comment 3 EWS Watchlist 2019-03-05 04:55:37 PST Comment hidden (obsolete)
Comment 4 Matt Baker 2019-03-05 10:58:28 PST
Comment on attachment 363626 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363626&action=review

r=me

> Source/WebInspectorUI/UserInterface/Models/Recording.js:536
> +        this._swizzle = null;

Style: this can go after this._processing = false. I don't think it's necessary to separate these by group.
Comment 5 Devin Rousso 2019-03-05 13:27:20 PST
Created attachment 363682 [details]
Patch
Comment 6 WebKit Commit Bot 2019-03-05 14:05:21 PST
Comment on attachment 363682 [details]
Patch

Clearing flags on attachment: 363682

Committed r242511: <https://trac.webkit.org/changeset/242511>
Comment 7 WebKit Commit Bot 2019-03-05 14:05:23 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-03-05 14:06:25 PST
<rdar://problem/48613617>