Bug 195292

Summary: Web Inspector: Audit: show the version number in the UI
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 190754    
Bug Blocks:    
Attachments:
Description Flags
Patch
mattbaker: review+
[Image] After Patch is applied
none
Patch none

Description Devin Rousso 2019-03-04 12:34:29 PST
There should be some place for the current Audit version number (the minimum of the frontend and backend versions) to be visible so developers are able to target it when writing tests.
Comment 1 Radar WebKit Bug Importer 2019-03-04 12:35:17 PST
<rdar://problem/48572784>
Comment 2 Devin Rousso 2019-03-04 13:16:16 PST
Created attachment 363546 [details]
Patch
Comment 3 Devin Rousso 2019-03-04 13:16:35 PST
Created attachment 363547 [details]
[Image] After Patch is applied
Comment 4 Matt Baker 2019-03-04 14:14:17 PST
Comment on attachment 363546 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363546&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/AuditNavigationSidebarPanel.css:81
> +    font-size: 14px;

This should be 13px to match the font-size used for the body text of the "Editing Audits" .message-text-view element.
Comment 5 Devin Rousso 2019-03-04 14:19:06 PST
Created attachment 363551 [details]
Patch
Comment 6 WebKit Commit Bot 2019-03-04 14:57:18 PST
Comment on attachment 363551 [details]
Patch

Clearing flags on attachment: 363551

Committed r242395: <https://trac.webkit.org/changeset/242395>
Comment 7 WebKit Commit Bot 2019-03-04 14:57:20 PST
All reviewed patches have been landed.  Closing bug.