iOS: Using ⌥ to scroll horizontally is no different than arrow key

• Component: New Bugs
• Status: RESOLVED FIXED

[Tim Horton]

iOS: Using ⌥ to scroll horizontally is no different than arrow key

[Tim Horton]

Created attachment 363496 [details]
Patch

[Tim Horton]

<rdar://problem/48326682>

[Brent Fulgham]

Comment on attachment 363496 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363496&action=review

> Source/WebKit/ChangeLog:3
> +        iOS: Using ⥠to scroll horizontally is no different than arrow key

Should this comment be ASCII only?

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4428
> +        return directionIsHorizontal ? documentSize.width : documentSize.height;

We could have a helper function that converted ScrollingDirection + CGSize to the right output. Then it could be used in WKKeyboardScrollingAnimator.mm 'distanceForIncrement', too.

But not today.

[Darin Adler]

Comment on attachment 363496 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363496&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4435
>          return [self convertSize:CGSizeMake(0, WebCore::Scrollbar::pixelsPerLineStep()) toView:_webView].height;

Should this assert !horizontal?

[Tim Horton]

Comment on attachment 363496 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363496&action=review

>> Source/WebKit/ChangeLog:3
>> +        iOS: Using ⥠to scroll horizontally is no different than arrow key
> 
> Should this comment be ASCII only?

No, the only thing that has a problem with this is the review tool. We have this problem a lot with smart quotes too :)

>> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4435
>>          return [self convertSize:CGSizeMake(0, WebCore::Scrollbar::pixelsPerLineStep()) toView:_webView].height;
> 
> Should this assert !horizontal?

No, definitely not. The default left/right arrow key behavior is "by line" and uses the vertical line height.

[WebKit Commit Bot]

Comment on attachment 363496 [details]
Patch

Clearing flags on attachment: 363496

Committed r242695: <https://trac.webkit.org/changeset/242695>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.