Bug 195263

Summary:

Rid the world of WK_API_ENABLED

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

New Bugs

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aestes, andersca, commit-queue, ews-watchlist, mitz, sam, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Tim Horton

Reported 2019-03-03 18:49:04 PST

Rid the world of WK_API_ENABLED

Attachments
Patch (492.59 KB, patch) 2019-03-03 18:53 PST, Tim Horton	no flags	Details Formatted Diff Diff
Patch (492.59 KB, patch) 2019-03-03 19:25 PST, Tim Horton	no flags	Details Formatted Diff Diff
Patch (492.56 KB, patch) 2019-03-03 20:15 PST, Tim Horton	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Tim Horton

Comment 1 2019-03-03 18:53:05 PST

Created attachment 363474 [details] Patch

EWS Watchlist

Comment 2 2019-03-03 18:55:30 PST

Attachment 363474 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm:30: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/NowPlaying.mm:28: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:28: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:28: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 4 in 150 files If any of these errors are false positives, please file a bug against check-webkit-style.

mitz

Comment 3 2019-03-03 19:07:09 PST

Comment on attachment 363474 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363474&action=review > Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextController.mm:-732 > -#else > - return nil; This method still needs to return something. > Source/WebKit/UIProcess/API/Cocoa/WKPreviewActionItem.mm:29 > +#if TARGET_OS_IPHONE PLATFORM(MAC)? > Source/WebKit/UIProcess/API/Cocoa/_WKGeolocationPosition.mm:29 > +#if TARGET_OS_IPHONE PLATFORM(IOS_FAMILY)?

Tim Horton

Comment 4 2019-03-03 19:25:02 PST

Created attachment 363477 [details] Patch

EWS Watchlist

Comment 5 2019-03-03 19:27:51 PST

Attachment 363477 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm:30: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/NowPlaying.mm:28: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:28: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:28: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 4 in 150 files If any of these errors are false positives, please file a bug against check-webkit-style.

Tim Horton

Comment 6 2019-03-03 20:15:04 PST

Created attachment 363479 [details] Patch

EWS Watchlist

Comment 7 2019-03-03 20:17:38 PST

Attachment 363479 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm:30: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/NowPlaying.mm:28: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:28: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:28: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 4 in 151 files If any of these errors are false positives, please file a bug against check-webkit-style.

Tim Horton

Comment 8 2019-03-03 20:48:10 PST

(In reply to mitz from comment #3) > Comment on attachment 363474 [details] > Patch > > View in context: > > Source/WebKit/UIProcess/API/Cocoa/WKPreviewActionItem.mm:29 > > +#if TARGET_OS_IPHONE > > PLATFORM(MAC)? I don't think so?

WebKit Commit Bot

Comment 9 2019-03-03 21:13:00 PST

Comment on attachment 363479 [details] Patch Clearing flags on attachment: 363479 Committed r242339: <https://trac.webkit.org/changeset/242339>

WebKit Commit Bot

Comment 10 2019-03-03 21:13:02 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 11 2019-03-03 21:14:27 PST

<rdar://problem/48550486>

Note You need to log in before you can comment on or make changes to this bug.