| Summary: | Rid the world of WK_API_ENABLED | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | aestes, andersca, commit-queue, ews-watchlist, mitz, sam, simon.fraser, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Tim Horton
2019-03-03 18:49:04 PST
Created attachment 363474 [details]
Patch
Attachment 363474 [details] did not pass style-queue:
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm:30: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/NowPlaying.mm:28: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:28: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:28: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5]
Total errors found: 4 in 150 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 363474 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363474&action=review > Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextController.mm:-732 > -#else > - return nil; This method still needs to return something. > Source/WebKit/UIProcess/API/Cocoa/WKPreviewActionItem.mm:29 > +#if TARGET_OS_IPHONE PLATFORM(MAC)? > Source/WebKit/UIProcess/API/Cocoa/_WKGeolocationPosition.mm:29 > +#if TARGET_OS_IPHONE PLATFORM(IOS_FAMILY)? Created attachment 363477 [details]
Patch
Attachment 363477 [details] did not pass style-queue:
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm:30: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/NowPlaying.mm:28: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:28: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:28: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5]
Total errors found: 4 in 150 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 363479 [details]
Patch
Attachment 363479 [details] did not pass style-queue:
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm:30: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/NowPlaying.mm:28: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:28: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:28: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5]
Total errors found: 4 in 151 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to mitz from comment #3) > Comment on attachment 363474 [details] > Patch > > View in context: > > Source/WebKit/UIProcess/API/Cocoa/WKPreviewActionItem.mm:29 > > +#if TARGET_OS_IPHONE > > PLATFORM(MAC)? I don't think so? Comment on attachment 363479 [details] Patch Clearing flags on attachment: 363479 Committed r242339: <https://trac.webkit.org/changeset/242339> All reviewed patches have been landed. Closing bug. |