Bug 195250

Summary: [JSC] Make Reflect lazily-allocated by dropping @Reflect references from builtin JS
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, joepeck, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch saam: review+

Yusuke Suzuki
Reported 2019-03-02 13:18:44 PST
[JSC] Make Reflect lazily-allocated by dropping @Reflect references from builtin JS
Attachments
Patch (11.08 KB, patch)
2019-03-02 13:21 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (11.49 KB, patch)
2019-03-02 13:25 PST, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-03-02 13:21:16 PST
Created attachment 363430 [details] Patch
Yusuke Suzuki
Comment 2 2019-03-02 13:25:43 PST
Created attachment 363431 [details] Patch
Saam Barati
Comment 3 2019-03-04 11:45:41 PST
Comment on attachment 363431 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363431&action=review > Source/JavaScriptCore/runtime/ObjectConstructor.cpp:286 > +EncodedJSValue JSC_HOST_CALL objectConstructorOwnKeys(ExecState* exec) Why not just make it a global function? I feel like we tend to have private properties reflect their public ones. But there is no corresponding public property here.
Yusuke Suzuki
Comment 4 2019-03-04 12:23:21 PST
Comment on attachment 363431 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363431&action=review Thanks! >> Source/JavaScriptCore/runtime/ObjectConstructor.cpp:286 >> +EncodedJSValue JSC_HOST_CALL objectConstructorOwnKeys(ExecState* exec) > > Why not just make it a global function? I feel like we tend to have private properties reflect their public ones. But there is no corresponding public property here. Yes, it looks better. I will put @ownKeys function in a global variable.
Yusuke Suzuki
Comment 5 2019-03-04 13:20:33 PST
Committed r242382: <https://trac.webkit.org/changeset/242382>
Radar WebKit Bug Importer
Comment 6 2019-03-04 13:22:11 PST
<rdar://problem/48574399>
Note You need to log in before you can comment on or make changes to this bug.