| Summary: | [JSC] Make Reflect lazily-allocated by dropping @Reflect references from builtin JS | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ews-watchlist, joepeck, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Yusuke Suzuki
2019-03-02 13:18:44 PST
Created attachment 363430 [details]
Patch
Created attachment 363431 [details]
Patch
Comment on attachment 363431 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363431&action=review > Source/JavaScriptCore/runtime/ObjectConstructor.cpp:286 > +EncodedJSValue JSC_HOST_CALL objectConstructorOwnKeys(ExecState* exec) Why not just make it a global function? I feel like we tend to have private properties reflect their public ones. But there is no corresponding public property here. Comment on attachment 363431 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363431&action=review Thanks! >> Source/JavaScriptCore/runtime/ObjectConstructor.cpp:286 >> +EncodedJSValue JSC_HOST_CALL objectConstructorOwnKeys(ExecState* exec) > > Why not just make it a global function? I feel like we tend to have private properties reflect their public ones. But there is no corresponding public property here. Yes, it looks better. I will put @ownKeys function in a global variable. Committed r242382: <https://trac.webkit.org/changeset/242382> |