Bug 195239

Summary: Web Inspector: Toggling Timeline "Stop when page loads" to on should stop (immediately or soon) any active recording if already past the load event
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Joseph Pecoraro
Reported 2019-03-01 20:28:00 PST
Toggling Timeline "Stop when page loads" to on should stop (immediately or soon) any active recording if already past the load event I'd suggest if after load tickling the dead timeout so we would stop within 2s.
Attachments
Patch (1.84 KB, patch)
2019-03-02 15:47 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (1.86 KB, patch)
2019-03-03 21:53 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2019-03-02 15:47:17 PST
Created attachment 363435 [details] Patch
Devin Rousso
Comment 2 2019-03-03 21:53:12 PST
Created attachment 363486 [details] Patch
Joseph Pecoraro
Comment 3 2019-03-04 11:57:51 PST
Comment on attachment 363486 [details] Patch r=me, Nice!
WebKit Commit Bot
Comment 4 2019-03-04 12:23:54 PST
Comment on attachment 363486 [details] Patch Clearing flags on attachment: 363486 Committed r242370: <https://trac.webkit.org/changeset/242370>
WebKit Commit Bot
Comment 5 2019-03-04 12:23:56 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-03-04 12:24:55 PST
<rdar://problem/48572456>
Note You need to log in before you can comment on or make changes to this bug.