Bug 195232

Summary: Web Inspector: Data grid border colors don't match accent colors
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Image] Bug
none
Patch
none
[Image] With patch applied none

Nikita Vasilyev
Reported 2019-03-01 15:48:11 PST
Created attachment 363383 [details] [Image] Bug Borders of selected items are always blue. It looks wrong with all accent colors except blue.
Attachments
[Image] Bug (18.68 KB, image/png)
2019-03-01 15:48 PST, Nikita Vasilyev 		no flags
Details
Patch (1.69 KB, patch)
2019-03-01 15:50 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
[Image] With patch applied (22.03 KB, image/png)
2019-03-01 15:52 PST, Nikita Vasilyev 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Nikita Vasilyev
Comment 1 2019-03-01 15:50:52 PST
Created attachment 363384 [details] Patch
Nikita Vasilyev
Comment 2 2019-03-01 15:52:24 PST
Created attachment 363385 [details] [Image] With patch applied
Matt Baker
Comment 3 2019-03-01 16:11:18 PST
Comment on attachment 363384 [details] Patch r=me. I did a few spot checks, comparing selected rows in DataGrid and Table with a few accents and light/dark. Looks good!
WebKit Commit Bot
Comment 4 2019-03-01 16:37:24 PST
Comment on attachment 363384 [details] Patch Clearing flags on attachment: 363384 Committed r242296: <https://trac.webkit.org/changeset/242296>
WebKit Commit Bot
Comment 5 2019-03-01 16:37:26 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-03-01 16:45:20 PST
<rdar://problem/48528297>
Note You need to log in before you can comment on or make changes to this bug.