Bug 195230

Summary:

Disable NetworkStateNotifier::singleton()'s isMainThread() assertion when the WebThread is enabled

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

WebCore Misc.

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Chris Dumez 2019-03-01 14:47:07 PST

Disable NetworkStateNotifier::singleton()'s isMainThread() assertion when the WebThread is enabled to address crashes on iOS WK1.

Comment 1 Chris Dumez 2019-03-01 14:47:25 PST

<rdar://problem/47925359>

Comment 2 Chris Dumez 2019-03-01 14:48:52 PST

Created attachment 363378 [details]
Patch

Comment 3 Ryosuke Niwa 2019-03-01 14:59:30 PST

Comment on attachment 363378 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363378&action=review

> Source/WebCore/platform/network/NetworkStateNotifier.cpp:41
> +#if PLATFORM(IOS_FAMILY)

Why not #if USE(WEB_THREAD)?

Comment 4 Chris Dumez 2019-03-01 15:53:14 PST

Created attachment 363386 [details]
Patch

Comment 5 WebKit Commit Bot 2019-03-01 16:30:44 PST

Comment on attachment 363386 [details]
Patch

Clearing flags on attachment: 363386

Committed r242295: <https://trac.webkit.org/changeset/242295>

Comment 6 WebKit Commit Bot 2019-03-01 16:30:46 PST

All reviewed patches have been landed.  Closing bug.