Bug 195230

Summary: Disable NetworkStateNotifier::singleton()'s isMainThread() assertion when the WebThread is enabled
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2019-03-01 14:47:07 PST
Disable NetworkStateNotifier::singleton()'s isMainThread() assertion when the WebThread is enabled to address crashes on iOS WK1.
Attachments
Patch (1.90 KB, patch)
2019-03-01 14:48 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (1.93 KB, patch)
2019-03-01 15:53 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2019-03-01 14:47:25 PST
<rdar://problem/47925359>
Chris Dumez
Comment 2 2019-03-01 14:48:52 PST
Created attachment 363378 [details] Patch
Ryosuke Niwa
Comment 3 2019-03-01 14:59:30 PST
Comment on attachment 363378 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363378&action=review > Source/WebCore/platform/network/NetworkStateNotifier.cpp:41 > +#if PLATFORM(IOS_FAMILY) Why not #if USE(WEB_THREAD)?
Chris Dumez
Comment 4 2019-03-01 15:53:14 PST
Created attachment 363386 [details] Patch
WebKit Commit Bot
Comment 5 2019-03-01 16:30:44 PST
Comment on attachment 363386 [details] Patch Clearing flags on attachment: 363386 Committed r242295: <https://trac.webkit.org/changeset/242295>
WebKit Commit Bot
Comment 6 2019-03-01 16:30:46 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.