Bug 195229

Summary: Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2019-03-01 14:25:14 PST
Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
Attachments
Patch (11.22 KB, patch)
2019-03-01 14:28 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (14.14 KB, patch)
2019-03-01 14:56 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (15.25 KB, patch)
2019-03-01 16:39 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (15.25 KB, patch)
2019-03-01 18:16 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2019-03-01 14:28:51 PST
Created attachment 363374 [details] Patch
Alex Christensen
Comment 2 2019-03-01 14:56:01 PST
Created attachment 363379 [details] Patch
Alex Christensen
Comment 3 2019-03-01 16:39:23 PST
Created attachment 363389 [details] Patch
Chris Dumez
Comment 4 2019-03-01 16:52:26 PST
Comment on attachment 363389 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363389&action=review r=me but please check EWS. > Source/WebKit/ChangeLog:12 > + Functionality verified by manual testing. See radar. extra space. > Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:203 > + const String& sourceApplicationBundleIdentifier() { return m_sourceApplicationBundleIdentifier; } const > Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:206 > + const String& sourceApplicationSecondaryIdentifier() { return m_sourceApplicationSecondaryIdentifier; } const
Alex Christensen
Comment 5 2019-03-01 18:16:06 PST
Created attachment 363393 [details] Patch
Alex Christensen
Comment 6 2019-03-01 18:24:01 PST
(In reply to Chris Dumez from comment #4) > > Source/WebKit/ChangeLog:12 > > + Functionality verified by manual testing. See radar. > > extra space. I read https://en.wikipedia.org/wiki/Sentence_spacing and decided to stick with double space after the period.
Alex Christensen
Comment 7 2019-03-01 18:27:33 PST
http://trac.webkit.org/r242302
Radar WebKit Bug Importer
Comment 8 2019-03-01 18:28:58 PST
<rdar://problem/48530825>
Chris Dumez
Comment 10 2019-03-01 19:13:29 PST
(In reply to Chris Dumez from comment #9) > Broke the windows build: > https://build.webkit.org/builders/WinCairo%2064- > bit%20WKL%20Release%20%28Build%29/builds/7430/steps/compile-webkit/logs/stdio Fix attempt: <https://trac.webkit.org/changeset/242305>
Chris Dumez
Comment 11 2019-03-01 19:14:33 PST
I did say "Please watch EWS". GTK / WPE were red. Windows was also broken.
Alex Christensen
Comment 12 2019-03-01 19:16:40 PST
:/ Thanks, Chris
Note You need to log in before you can comment on or make changes to this bug.