| Summary: | Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | cdumez, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Alex Christensen
2019-03-01 14:25:14 PST
Created attachment 363374 [details]
Patch
Created attachment 363379 [details]
Patch
Created attachment 363389 [details]
Patch
Comment on attachment 363389 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363389&action=review r=me but please check EWS. > Source/WebKit/ChangeLog:12 > + Functionality verified by manual testing. See radar. extra space. > Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:203 > + const String& sourceApplicationBundleIdentifier() { return m_sourceApplicationBundleIdentifier; } const > Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:206 > + const String& sourceApplicationSecondaryIdentifier() { return m_sourceApplicationSecondaryIdentifier; } const Created attachment 363393 [details]
Patch
(In reply to Chris Dumez from comment #4) > > Source/WebKit/ChangeLog:12 > > + Functionality verified by manual testing. See radar. > > extra space. I read https://en.wikipedia.org/wiki/Sentence_spacing and decided to stick with double space after the period. Broke the windows build: https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Release%20%28Build%29/builds/7430/steps/compile-webkit/logs/stdio (In reply to Chris Dumez from comment #9) > Broke the windows build: > https://build.webkit.org/builders/WinCairo%2064- > bit%20WKL%20Release%20%28Build%29/builds/7430/steps/compile-webkit/logs/stdio Fix attempt: <https://trac.webkit.org/changeset/242305> I did say "Please watch EWS". GTK / WPE were red. Windows was also broken. :/ Thanks, Chris |