Bug 195229

Summary: Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Alex Christensen 2019-03-01 14:25:14 PST
Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
Comment 1 Alex Christensen 2019-03-01 14:28:51 PST
Created attachment 363374 [details]
Patch
Comment 2 Alex Christensen 2019-03-01 14:56:01 PST
Created attachment 363379 [details]
Patch
Comment 3 Alex Christensen 2019-03-01 16:39:23 PST
Created attachment 363389 [details]
Patch
Comment 4 Chris Dumez 2019-03-01 16:52:26 PST
Comment on attachment 363389 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363389&action=review

r=me but please check EWS.

> Source/WebKit/ChangeLog:12
> +        Functionality verified by manual testing.  See radar.

extra space.

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:203
> +    const String& sourceApplicationBundleIdentifier() { return m_sourceApplicationBundleIdentifier; }

const

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:206
> +    const String& sourceApplicationSecondaryIdentifier() { return m_sourceApplicationSecondaryIdentifier; }

const
Comment 5 Alex Christensen 2019-03-01 18:16:06 PST
Created attachment 363393 [details]
Patch
Comment 6 Alex Christensen 2019-03-01 18:24:01 PST
(In reply to Chris Dumez from comment #4)
> > Source/WebKit/ChangeLog:12
> > +        Functionality verified by manual testing.  See radar.
> 
> extra space.

I read https://en.wikipedia.org/wiki/Sentence_spacing and decided to stick with double space after the period.
Comment 7 Alex Christensen 2019-03-01 18:27:33 PST
http://trac.webkit.org/r242302
Comment 8 Radar WebKit Bug Importer 2019-03-01 18:28:58 PST
<rdar://problem/48530825>
Comment 10 Chris Dumez 2019-03-01 19:13:29 PST
(In reply to Chris Dumez from comment #9)
> Broke the windows build:
> https://build.webkit.org/builders/WinCairo%2064-
> bit%20WKL%20Release%20%28Build%29/builds/7430/steps/compile-webkit/logs/stdio

Fix attempt: <https://trac.webkit.org/changeset/242305>
Comment 11 Chris Dumez 2019-03-01 19:14:33 PST
I did say "Please watch EWS". GTK / WPE were red. Windows was also broken.
Comment 12 Alex Christensen 2019-03-01 19:16:40 PST
:/
Thanks, Chris