Bug 195194

Summary: HTTPSUpgradeList.db database should be opened in readonly mode
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Severity: Normal CC: achristensen, beidson, commit-queue, don.olmstead, ggaren, simon.fraser, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 195237    
Bug Blocks:    
Description Flags
Patch none

Description Chris Dumez 2019-02-28 16:46:03 PST
HTTPSUpgradeList.db database should be opened in readonly mode since it is not meant to be modified by WebKit. Opening it in ReadWrite mode causes sandbox violations.
Comment 1 Chris Dumez 2019-02-28 16:46:16 PST
Comment 2 Chris Dumez 2019-02-28 16:47:58 PST
Created attachment 363276 [details]
Comment 3 WebKit Commit Bot 2019-02-28 18:47:38 PST
Comment on attachment 363276 [details]

Clearing flags on attachment: 363276

Committed r242251: <https://trac.webkit.org/changeset/242251>
Comment 4 WebKit Commit Bot 2019-02-28 18:47:40 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Don Olmstead 2019-02-28 19:26:35 PST
This broke the WinCairo build.
Comment 6 Chris Dumez 2019-02-28 19:41:46 PST
(In reply to Don Olmstead from comment #5)
> This broke the WinCairo build.

Comment 7 Simon Fraser (smfr) 2019-03-01 17:34:43 PST
Now I get logging every time I launch:

ERROR: SQLite database failed to set journal_mode to WAL, error: attempt to write a readonly database
./platform/sql/SQLiteDatabase.cpp(137) : bool WebCore::SQLiteDatabase::open(const WTF::String &, WebCore::SQLiteDatabase::OpenMode)