Bug 195189

Summary: Do not share WebProcesses between private and regular sessions
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, achristensen, ap, beidson, commit-queue, ews-watchlist, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 195212    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews126 for ios-simulator-wk2
none
Archive of layout-test-results from ews117 for mac-highsierra
none
Patch
none
Patch
none
Archive of layout-test-results from ews112 for mac-highsierra none

Chris Dumez
Reported 2019-02-28 15:41:01 PST
Do not share WebProcesses between private and regular sessions. There are some privacy concerns. Also, some of the WebsiteDataStore informations are passed via WebProcessCreationParameters (e.g. ApplicationCache path) and cannot be updated later.
Attachments
Patch (42.27 KB, patch)
2019-02-28 15:51 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (2.71 MB, application/zip)
2019-02-28 17:55 PST, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews117 for mac-highsierra (1.59 MB, application/zip)
2019-03-01 02:21 PST, EWS Watchlist 		no flags
Details
Patch (42.27 KB, patch)
2019-03-01 08:55 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (43.02 KB, patch)
2019-03-01 12:41 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews112 for mac-highsierra (1.68 MB, application/zip)
2019-03-01 18:08 PST, EWS Watchlist 		no flags
Details
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2019-02-28 15:41:17 PST
<rdar://problem/48421064>
Chris Dumez
Comment 2 2019-02-28 15:51:51 PST
Created attachment 363269 [details] Patch
EWS Watchlist
Comment 3 2019-02-28 17:55:56 PST
Comment on attachment 363269 [details] Patch Attachment 363269 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11323765 New failing tests: imported/w3c/web-platform-tests/webrtc/simplecall-no-ssrcs.https.html
EWS Watchlist
Comment 4 2019-02-28 17:55:58 PST
Created attachment 363282 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
EWS Watchlist
Comment 5 2019-03-01 02:21:01 PST
Comment on attachment 363269 [details] Patch Attachment 363269 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/11328040 New failing tests: storage/indexeddb/modern/blocked-open-db-requests-private.html
EWS Watchlist
Comment 6 2019-03-01 02:21:03 PST
Created attachment 363317 [details] Archive of layout-test-results from ews117 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-highsierra Platform: Mac OS X 10.13.6
Chris Dumez
Comment 7 2019-03-01 08:55:42 PST
Created attachment 363332 [details] Patch
Aakash Jain
Comment 8 2019-03-01 11:36:07 PST
This patch seems to break the following API Test: TestWebKitAPI.WKProcessPool.InitialWarmedProcessUsed mac: https://ews-build.webkit-uat.org/#/builders/19/builds/1405 iOS: https://ews-build.webkit-uat.org/#/builders/20/builds/1169 If this is a false positive, please let us know.
Aakash Jain
Comment 9 2019-03-01 11:41:43 PST
(In reply to Chris Dumez from comment #2) > Created attachment 363269 [details] Similar API Test failure with this previous patch in: mac: https://ews-build.webkit-uat.org/#/builders/19/builds/1376 ios: https://ews-build.webkit-uat.org/#/builders/20/builds/1140
Chris Dumez
Comment 10 2019-03-01 11:47:05 PST
(In reply to Aakash Jain from comment #9) > (In reply to Chris Dumez from comment #2) > > Created attachment 363269 [details] > > Similar API Test failure with this previous patch in: > > mac: https://ews-build.webkit-uat.org/#/builders/19/builds/1376 > ios: https://ews-build.webkit-uat.org/#/builders/20/builds/1140 Awesome. Thanks for the heads-up. Already benefitting from API test EWS!
Chris Dumez
Comment 11 2019-03-01 12:41:23 PST
Created attachment 363356 [details] Patch
Aakash Jain
Comment 12 2019-03-01 15:17:16 PST
(In reply to Chris Dumez from comment #11) > Created attachment 363356 [details] API Tests pass now: mac: https://ews-build.webkit-uat.org/#/builders/19/builds/1419 ios: https://ews-build.webkit-uat.org/#/builders/20/builds/1183 (Ignore the failures in this run, they are due to flaky tests)
EWS Watchlist
Comment 13 2019-03-01 18:08:41 PST
Comment on attachment 363356 [details] Patch Attachment 363356 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/11337447 New failing tests: storage/indexeddb/modern/createobjectstore-basic-private.html
EWS Watchlist
Comment 14 2019-03-01 18:08:43 PST
Created attachment 363392 [details] Archive of layout-test-results from ews112 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-highsierra Platform: Mac OS X 10.13.6
Chris Dumez
Comment 15 2019-03-01 18:16:07 PST
Comment on attachment 363356 [details] Patch Patch is wk2 only, the Mac wk1 ews failure must be a flake.
Chris Dumez
Comment 16 2019-03-04 11:44:18 PST
ping review? This is blocking some of my other work.
Chris Dumez
Comment 17 2019-03-04 12:26:10 PST
Comment on attachment 363356 [details] Patch Clearing flags on attachment: 363356 Committed r242371: <https://trac.webkit.org/changeset/242371>
Chris Dumez
Comment 18 2019-03-04 12:26:12 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.