| Summary: | Do not share WebProcesses between private and regular sessions | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||||||
| Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | aakash_jain, achristensen, ap, beidson, commit-queue, ews-watchlist, ggaren, webkit-bug-importer | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Bug Depends on: | |||||||||||||||||
| Bug Blocks: | 195212 | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Chris Dumez
2019-02-28 15:41:01 PST
Created attachment 363269 [details]
Patch
Comment on attachment 363269 [details] Patch Attachment 363269 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11323765 New failing tests: imported/w3c/web-platform-tests/webrtc/simplecall-no-ssrcs.https.html Created attachment 363282 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 363269 [details] Patch Attachment 363269 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/11328040 New failing tests: storage/indexeddb/modern/blocked-open-db-requests-private.html Created attachment 363317 [details]
Archive of layout-test-results from ews117 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 363332 [details]
Patch
This patch seems to break the following API Test: TestWebKitAPI.WKProcessPool.InitialWarmedProcessUsed mac: https://ews-build.webkit-uat.org/#/builders/19/builds/1405 iOS: https://ews-build.webkit-uat.org/#/builders/20/builds/1169 If this is a false positive, please let us know. (In reply to Chris Dumez from comment #2) > Created attachment 363269 [details] Similar API Test failure with this previous patch in: mac: https://ews-build.webkit-uat.org/#/builders/19/builds/1376 ios: https://ews-build.webkit-uat.org/#/builders/20/builds/1140 (In reply to Aakash Jain from comment #9) > (In reply to Chris Dumez from comment #2) > > Created attachment 363269 [details] > > Similar API Test failure with this previous patch in: > > mac: https://ews-build.webkit-uat.org/#/builders/19/builds/1376 > ios: https://ews-build.webkit-uat.org/#/builders/20/builds/1140 Awesome. Thanks for the heads-up. Already benefitting from API test EWS! Created attachment 363356 [details]
Patch
(In reply to Chris Dumez from comment #11) > Created attachment 363356 [details] API Tests pass now: mac: https://ews-build.webkit-uat.org/#/builders/19/builds/1419 ios: https://ews-build.webkit-uat.org/#/builders/20/builds/1183 (Ignore the failures in this run, they are due to flaky tests) Comment on attachment 363356 [details] Patch Attachment 363356 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/11337447 New failing tests: storage/indexeddb/modern/createobjectstore-basic-private.html Created attachment 363392 [details]
Archive of layout-test-results from ews112 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 363356 [details]
Patch
Patch is wk2 only, the Mac wk1 ews failure must be a flake.
ping review? This is blocking some of my other work. Comment on attachment 363356 [details] Patch Clearing flags on attachment: 363356 Committed r242371: <https://trac.webkit.org/changeset/242371> All reviewed patches have been landed. Closing bug. |