Bug 19512

Summary: Unquoted $ORIGDIR in autogen.sh
Product: WebKit Reporter: Julien Sanchez <julien.sanchez>
Component: WebKitGTKAssignee: Alberto Garcia <berto>
Status: RESOLVED FIXED    
Severity: Trivial CC: berto, cgarcia, julien.sanchez, pnormand
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch
none
Patch cgarcia: review+

Julien Sanchez
Reported 2008-06-12 00:39:04 PDT
$ORIGDIR must be quoted to build inside a directory with space
Attachments
Patch (1.33 KB, patch)
2013-09-11 01:24 PDT, Alberto Garcia 		no flags
DetailsFormatted DiffDiff
Patch (1.40 KB, patch)
2013-09-11 02:42 PDT, Alberto Garcia 		cgarcia: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alberto Garcia
Comment 1 2013-09-11 01:24:50 PDT
Created attachment 211288 [details] Patch I'm not sure why anyone would want to build inside a directory with this kind of names, but configure will anyway make a proper safety check.
Carlos Garcia Campos
Comment 2 2013-09-11 02:12:51 PDT
Comment on attachment 211288 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211288&action=review > autogen.sh:11 > -rm -f $top_srcdir/autom4te.cache > +rm -rf autom4te.cache Is this related to this bug? or can it be fixed in a different commit?
Alberto Garcia
Comment 3 2013-09-11 02:26:23 PDT
Not directly related, I was just trying to sanitize autogen.sh a bit. Not sure if the autom4te thing deserves its own patch, but I can also file a separate bug, of course.
Carlos Garcia Campos
Comment 4 2013-09-11 02:33:50 PDT
(In reply to comment #3) > Not directly related, I was just trying to sanitize autogen.sh a bit. > > Not sure if the autom4te thing deserves its own patch, but I can also file a separate bug, of course. Yes, please, even if it's one line patch it's a different fix
Alberto Garcia
Comment 5 2013-09-11 02:42:20 PDT
Created attachment 211291 [details] Patch So be it
Alberto Garcia
Comment 6 2013-09-11 02:53:26 PDT
Committed r155515: <http://trac.webkit.org/changeset/155515>
Note You need to log in before you can comment on or make changes to this bug.