Summary: | Move NetworkProcess/Classifier/ResourceLoadStatisticsStoreCocoa.mm functionality into UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Aaron <alabiaga> | ||||||
Component: | New Bugs | Assignee: | John Wilander <wilander> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ap, bfulgham, commit-queue, webkit-bug-importer, wilander | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | Safari Technology Preview | ||||||||
Hardware: | Mac | ||||||||
OS: | macOS 10.14 | ||||||||
Attachments: |
|
Description
Aaron
2019-02-27 12:43:52 PST
Hi Aaron! Thanks for reporting. I will have a look. Thanks John, In the meantime I managed to find an older version of Safari tech preview and got this to work
>> log stream -info | grep ResourceLoadStatisticsDebug
2019-02-28 21:45:27.346931-0500 0x385a2 Info 0x0 26919 0 Safari Technology Preview: (WebKit) [com.apple.WebKit:ResourceLoadStatisticsDebug] Did set test-domain.org as prevalent resource for the purposes of ITP Debug Mode.
I think this is because WebKit/UIProcess/Cocoa/ResourceLoadStatisticsMemoryStoreCocoa.mm has not been moved to the network process. It could also make its calls over IPC. WebKit/UIProcess/Cocoa/ResourceLoadStatisticsMemoryStoreCocoa.mm reads user defaults to allow developers to set a custom domain as permanently classified under ITP Debug Mode. This was broken by the recent move of ITP from the UI process to the network process. Created attachment 364306 [details]
Patch
Comment on attachment 364306 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364306&action=review Looks good. > Source/WebKit/ChangeLog:13 > + This patch make away with some old user defaults we don't use anymore. It also "make away" -> "does away" (In reply to Brent Fulgham from comment #6) > Comment on attachment 364306 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=364306&action=review > > Looks good. > > > Source/WebKit/ChangeLog:13 > > + This patch make away with some old user defaults we don't use anymore. It also > > "make away" -> "does away" Thanks! Will fix and land. Created attachment 364331 [details]
Patch for landing
Comment on attachment 364331 [details] Patch for landing Clearing flags on attachment: 364331 Committed r242764: <https://trac.webkit.org/changeset/242764> All reviewed patches have been landed. Closing bug. |