Bug 195102

Summary:

Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, ap, beidson, cdumez, commit-queue, ggaren, lforschler, rniwa, webkit-bot-watchers-bugzilla, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=194894

Attachments:

Description	Flags
Patch	none
Patch	none

Aakash Jain

Reported 2019-02-27 10:02:07 PST

TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses seems flaky. In https://ews-build.webkit-uat.org/#/builders/19/builds/1299, the test Failed in run-api-tests step. However, in the immediately next retry step (re-run-api-tests), it passed.

Attachments
Patch (2.68 KB, patch) 2019-02-27 15:41 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (1.92 KB, patch) 2019-05-14 15:53 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Aakash Jain

Comment 1 2019-02-27 10:06:46 PST

This test was added recently in https://trac.webkit.org/changeset/241928/webkit

Chris Dumez

Comment 2 2019-02-27 15:31:54 PST

TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses Received data during response processing, queuing it. Received data during response processing, queuing it. Received data during response processing, queuing it. Received data during response processing, queuing it. /Volumes/Data/worker/macOS-High-Sierra-Release-Build-EWS/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:3131 Expected equality of these values: maxSuspendedPageCount + 1 Which is: 3 [processPool _webProcessCountIgnoringPrewarmedAndCached] Which is: 4 /Volumes/Data/worker/macOS-High-Sierra-Release-Build-EWS/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:3140 Expected equality of these values: 1u Which is: 1 [processPool _webProcessCount] Which is: 2

Chris Dumez

Comment 3 2019-02-27 15:41:18 PST

Created attachment 363145 [details] Patch

Geoffrey Garen

Comment 4 2019-02-27 16:19:48 PST

Comment on attachment 363145 [details] Patch r=me

WebKit Commit Bot

Comment 5 2019-02-27 16:47:47 PST

Comment on attachment 363145 [details] Patch Clearing flags on attachment: 363145 Committed r242180: <https://trac.webkit.org/changeset/242180>

WebKit Commit Bot

Comment 6 2019-02-27 16:47:49 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 7 2019-02-27 16:52:00 PST

<rdar://problem/48456786>

Aakash Jain

Comment 8 2019-03-20 05:18:27 PDT

Still noticed a flakiness in https://ews-build.webkit-uat.org/#/builders/19/builds/2249 This test failed in run-api-tests and re-run-api-tests steps, but passed in run-api-tests-without-patch step. Seems like a flaky test, unless that patch actually broke this test.

Aakash Jain

Comment 9 2019-03-20 06:11:27 PDT

Another flakiness instance: In https://ews-build.webkit-uat.org/#/builders/19/builds/2256 the test Passed in run-api-tests step. However, in the immediately next retry step (re-run-api-tests), it Failed.

Chris Dumez

Comment 10 2019-03-21 13:12:52 PDT

Latest failure: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses Received data during response processing, queuing it. Received data during response processing, queuing it. Received data during response processing, queuing it. Received data during response processing, queuing it. /Volumes/Data/worker/macOS-High-Sierra-Release-Build-EWS/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:3426 Expected equality of these values: maxSuspendedPageCount + 1 Which is: 3 [processPool _webProcessCountIgnoringPrewarmedAndCached] Which is: 4 /Volumes/Data/worker/macOS-High-Sierra-Release-Build-EWS/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:3441 Expected equality of these values: 1u Which is: 1 [processPool _webProcessCount] Which is: 2

Chris Dumez

Comment 11 2019-05-14 15:53:30 PDT

Created attachment 369903 [details] Patch

WebKit Commit Bot

Comment 12 2019-05-15 08:00:15 PDT

Comment on attachment 369903 [details] Patch Clearing flags on attachment: 369903 Committed r245323: <https://trac.webkit.org/changeset/245323>

WebKit Commit Bot

Comment 13 2019-05-15 08:00:17 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.