Bug 19510

Summary: CodeBlock::needsFullScopeChain not always set for global code
Product: WebKit Reporter: Cameron Zwarich (cpst) <zwarich>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren, mjs, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Test case
none
Patch to fix symptoms mjs: review+

Cameron Zwarich (cpst)
Reported 2008-06-11 22:38:04 PDT
If a unit of global code doesn't define any functions, the associated CodeBlock does not have needsFullScopeChain set. Since we use this to test for copying local variables to temporaries when necessary, it leads to incorrect behaviour. I will post a test case in the next post.
Attachments
Test case (180 bytes, text/html)
2008-06-11 22:39 PDT, Cameron Zwarich (cpst) 		no flags
Details
Patch to fix symptoms (5.71 KB, patch)
2008-06-12 01:57 PDT, Cameron Zwarich (cpst) 		mjs: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Cameron Zwarich (cpst)
Comment 1 2008-06-11 22:39:06 PDT
Created attachment 21653 [details] Test case
Cameron Zwarich (cpst)
Comment 2 2008-06-12 01:57:59 PDT
Created attachment 21657 [details] Patch to fix symptoms Here is a patch that fixes the symptoms, but we should still try to more clearly define the meaning of needsFullScopeChain.
Maciej Stachowiak
Comment 3 2008-06-12 01:59:26 PDT
Comment on attachment 21657 [details] Patch to fix symptoms r=me
Cameron Zwarich (cpst)
Comment 4 2008-06-12 02:05:35 PDT
Landed in r34510.
Note You need to log in before you can comment on or make changes to this bug.