Bug 195080

Summary:

[Apple Pay] Move WebPaymentCoordinatorProxy from Source/WebKit/UIProcess to Source/WebKit/Shared

Product:

WebKit

Reporter:

Andy Estes <aestes>

Component:

New Bugs

Assignee:

Andy Estes <aestes>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, commit-queue, darin, ews-watchlist, ggaren, koivisto, mkwst, thorton, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

195078

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Archive of layout-test-results from ews112 for mac-highsierra	none
Patch	none
Patch	none

Description Andy Estes 2019-02-26 16:57:39 PST

[Apple Pay] Move WebPaymentCoordinatorProxy from Source/WebKit/UIProcess to Source/WebKit/Shared

Comment 1 Radar WebKit Bug Importer 2019-02-26 16:59:39 PST

<rdar://problem/48421558>

Comment 2 Andy Estes 2019-02-26 17:48:06 PST Comment hidden (obsolete)

Created attachment 363048 [details]
Patch

Comment 3 EWS Watchlist 2019-02-26 17:50:48 PST Comment hidden (obsolete)

Attachment 363048 [details] did not pass style-queue:


ERROR: Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:48:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:51:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
ERROR: Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:52:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:53:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:54:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:55:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:57:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:58:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:59:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:60:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h:103:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h:104:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h:137:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h:152:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h:158:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h:161:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:40:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
ERROR: Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:69:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
ERROR: Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:117:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
ERROR: Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:121:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
ERROR: Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:136:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
ERROR: Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:149:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
ERROR: Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:163:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
ERROR: Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:177:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
ERROR: Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:264:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:266:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
ERROR: Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:287:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:297:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
ERROR: Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:419:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
ERROR: Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:433:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
ERROR: Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:460:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
ERROR: Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:468:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
ERROR: Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:504:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
ERROR: Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:525:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
ERROR: Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:694:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
ERROR: Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:721:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
ERROR: Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:730:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
ERROR: Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:773:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
ERROR: Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:790:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 39 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 4 Andy Estes 2019-02-28 11:30:29 PST Comment hidden (obsolete)

Created attachment 363241 [details]
Patch

Comment 5 EWS Watchlist 2019-02-28 11:34:33 PST Comment hidden (obsolete)

Attachment 363241 [details] did not pass style-queue:


ERROR: Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:55:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h:137:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h:152:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h:158:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h:161:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 5 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 6 Andy Estes 2019-02-28 15:04:57 PST Comment hidden (obsolete)

Created attachment 363265 [details]
Patch

Comment 7 EWS Watchlist 2019-02-28 15:09:49 PST Comment hidden (obsolete)

Attachment 363265 [details] did not pass style-queue:


ERROR: Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:55:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h:137:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h:152:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h:158:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h:161:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 5 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 8 EWS Watchlist 2019-03-01 00:19:18 PST Comment hidden (obsolete)

Comment on attachment 363265 [details]
Patch

Attachment 363265 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/11327190

New failing tests:
webgl/2.0.0/conformance/context/context-release-upon-reload.html

Comment 9 EWS Watchlist 2019-03-01 00:19:20 PST Comment hidden (obsolete)

Created attachment 363314 [details]
Archive of layout-test-results from ews112 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-highsierra  Platform: Mac OS X 10.13.6

Comment 10 Andy Estes 2019-03-03 17:42:21 PST Comment hidden (obsolete)

Created attachment 363472 [details]
Patch

Comment 11 EWS Watchlist 2019-03-03 17:44:57 PST Comment hidden (obsolete)

Attachment 363472 [details] did not pass style-queue:


ERROR: Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h:165:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h:180:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h:186:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h:189:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 4 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 12 Andy Estes 2019-03-03 18:07:02 PST

Created attachment 363473 [details]
Patch

Comment 13 EWS Watchlist 2019-03-03 18:09:42 PST

Attachment 363473 [details] did not pass style-queue:


ERROR: Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h:165:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h:180:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h:186:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h:189:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 4 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 14 Antti Koivisto 2019-03-04 01:49:10 PST

Comment on attachment 363473 [details]
Patch

rs=me

Comment 15 WebKit Commit Bot 2019-03-04 08:48:04 PST

Comment on attachment 363473 [details]
Patch

Clearing flags on attachment: 363473

Committed r242356: <https://trac.webkit.org/changeset/242356>

Comment 16 WebKit Commit Bot 2019-03-04 08:48:06 PST

All reviewed patches have been landed.  Closing bug.