Summary: | Assertion Failed: m_databaseQueue.isKilled() in UniqueIDBDatabase::~UniqueIDBDatabase() | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sihui Liu <sihui_liu> | ||||||||||
Component: | New Bugs | Assignee: | Sihui Liu <sihui_liu> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | alecflett, beidson, commit-queue, ews-watchlist, ggaren, jsbell, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Sihui Liu
2019-02-26 15:47:00 PST
Created attachment 363116 [details]
Patch
Created attachment 363139 [details]
Patch
Comment on attachment 363139 [details] Patch Attachment 363139 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/11309111 New failing tests: webgl/2.0.0/conformance/context/context-release-upon-reload.html Created attachment 363157 [details]
Archive of layout-test-results from ews114 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 363231 [details]
Patch
Comment on attachment 363231 [details]
Patch
Can you add a test for this?
(In reply to Geoffrey Garen from comment #7) > Comment on attachment 363231 [details] > Patch > > Can you add a test for this? For testing, we need to make sure ~IDBDatabase() and ~InProcessIDBServer() happen before the shutdown of UniqueIDBDatabase. For layout test, this means all WebPages using the same WebDatabaseProvider(the same webPageGroupID) should go away before UniqueIDBDatabase finishes its tasks. We can create a webpage with IDBDatabase by using window.open and then close it, but we cannot close all the other pages in the same group and force InProcessIDBServer to go away. We can probably make this test work by making WebDatabaseProvider not per page group but per page, but that seems not to be the correct direction. Comment on attachment 363231 [details] Patch Clearing flags on attachment: 363231 Committed r242555: <https://trac.webkit.org/changeset/242555> All reviewed patches have been landed. Closing bug. |