Bug 195054

Summary: [iOS] Regression(PSON) Scroll position is no longer restored when navigating back to reddit.com
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, commit-queue, ggaren, koivisto, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2019-02-26 10:20:20 PST 
Scroll position is no longer restored when navigating back to reddit.com on iOS when PSON is enabled.
Comment 1 Chris Dumez 2019-02-26 10:20:40 PST 
<rdar://problem/48330549>
Comment 2 Chris Dumez 2019-02-26 10:26:42 PST 
Created attachment 362991 [details]
Patch
Comment 3 Geoffrey Garen 2019-02-26 10:53:18 PST 
Comment on attachment 362991 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362991&action=review

r=me

Can you file a follow-up Radar about the UIProcess vs WebProcess scroll position mismatch on session restoration?

> Source/WebKit/ChangeLog:14
> +        and would there get reloaded abd finish loading *after* the load event.

=> would then get reloaded and

> Source/WebCore/page/MemoryRelease.cpp:88
> +        MemoryCache::singleton().pruneLiveResourcesToSize(0, /*shouldDestroyDecodedDataForAllLiveResources*/ true);

I'd prefer seeing "auto shouldDestroyDecodedDataForAllLiveResources = true; pruneLiveResourcesToSize(0, shouldDestroyDecodedDataForAllLiveResources);".
Comment 4 Chris Dumez 2019-02-26 11:56:17 PST 
Created attachment 363000 [details]
Patch
Comment 5 WebKit Commit Bot 2019-02-26 12:34:42 PST 
Comment on attachment 363000 [details]
Patch

Clearing flags on attachment: 363000

Committed r242099: <https://trac.webkit.org/changeset/242099>
Comment 6 WebKit Commit Bot 2019-02-26 12:34:44 PST 
All reviewed patches have been landed.  Closing bug.