| Summary: | [ews-app] Update method to save build to handle builder_display_name | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aakash_jain, ap, dean_johnson, dewei_zhu, ews-watchlist, jbedard, kocsen_chung, lforschler, slewis, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=194961 | ||||||
| Attachments: |
|
||||||
|
Description
Aakash Jain
2019-02-26 07:01:37 PST
Created attachment 362983 [details]
Proposed patch
Tested on a local instance. Attachment 362983 [details] did not pass style-queue:
ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/build.py:63: [Build.save_build] Instance of 'Build' has no 'save' member [pylint/E1101] [5]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
This almost feels like this should have been contained in <https://bugs.webkit.org/show_bug.cgi?id=194961>, any reason to separate them? > any reason to separate them?
I have been making smaller patches to make them easier to review. Previous reviewers found it easier to review multiple smaller patches as compared to a large patch.
Comment on attachment 362983 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=362983&action=review > Tools/BuildSlaveSupport/ews-app/ews/views/results.py:81 > + 'number', 'result', 'state_string', 'started_at', 'complete_at'], Nit: we need a consistent indentation. Usually 4 spaces. Committed r242198: <https://trac.webkit.org/changeset/242198> |