Summary: | REGRESSION (r34497): crash while loading GMail | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ismail Donmez <ismail> | ||||
Component: | JavaScriptCore | Assignee: | Cameron Zwarich (cpst) <zwarich> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Critical | CC: | darin, dev+webkit, ggaren, mjs, oliver, zwarich | ||||
Priority: | P1 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Ismail Donmez
2008-06-11 14:04:27 PDT
Looks like Cameron broke this with <http://trac.webkit.org/changeset/34497>. We figured out the problem. We're doing bad code generation when combining the less opcode with a branch in the logical or case because we are optimizing out a needed side effect. Cameron's working on a fix. Created attachment 21652 [details]
Proposed patch
Here it is.
Comment on attachment 21652 [details]
Proposed patch
r=me
|