Bug 194967

Summary: Web Inspector: Styles: Command-/ should toggle edited property
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gugunpratama632, hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
hi: review+
[Video] With patch applied
none
Patch for landing none

Nikita Vasilyev
Reported 2019-02-22 16:48:30 PST
Pressing Command-/ toggles *selected* CSS property. Bug 181145 - Web Inspector: Styles: Toggle selected properties by pressing Space or Command+/ It should also work when editing CSS property name or value. Steps: 1. Inspect <body> on webkit.org 2. Click on "font-size" (or it's value) 3. Press Command-/ (Ctrl-/ on non-Mac) Expected: "font-size" is commented out. font-size *property* is now selected - we need to select the property so consequent Command-/ would uncomment it. Actual: Nothing happens.
Attachments
Patch (3.54 KB, patch)
2019-02-23 16:09 PST, Nikita Vasilyev 		hi: review+
DetailsFormatted DiffDiff
[Video] With patch applied (726.61 KB, video/quicktime)
2019-02-23 16:15 PST, Nikita Vasilyev 		no flags
Details
Patch for landing (4.29 KB, patch)
2019-02-25 17:13 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-02-22 16:49:39 PST
<rdar://problem/48329852>
Nikita Vasilyev
Comment 2 2019-02-23 16:09:48 PST
Created attachment 362839 [details] Patch
Nikita Vasilyev
Comment 3 2019-02-23 16:15:15 PST
Created attachment 362840 [details] [Video] With patch applied
Devin Rousso
Comment 4 2019-02-25 13:52:45 PST
Comment on attachment 362839 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362839&action=review r=me Probably unrelated, but when I select multiple properties and press ⌘/, I hit an assertion failure. Models/CSSProperty.js:146:23: CONSOLE ERROR CSS property is already disabled We should probably just remove that assertion. > Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js:164 > + this._toggle(); NIT: we should assert (or even just set it) that the checkbox's state matches the property's `enabled`. console.assert(this._checkboxElement.checked === this.property.enabled); > Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js:423 > + const index = parseInt(this._element.dataset.propertyIndex); Style: this should be `let`.
Nikita Vasilyev
Comment 5 2019-02-25 17:13:33 PST
Created attachment 362944 [details] Patch for landing
WebKit Commit Bot
Comment 6 2019-02-25 17:50:51 PST
Comment on attachment 362944 [details] Patch for landing Clearing flags on attachment: 362944 Committed r242063: <https://trac.webkit.org/changeset/242063>
WebKit Commit Bot
Comment 7 2019-02-25 17:50:52 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.