Summary: | Web Inspector: Styles: Command-/ should toggle edited property | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nikita Vasilyev <nvasilyev> | ||||||||
Component: | Web Inspector | Assignee: | Nikita Vasilyev <nvasilyev> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, hi, inspector-bugzilla-changes, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Nikita Vasilyev
2019-02-22 16:48:30 PST
Created attachment 362839 [details]
Patch
Created attachment 362840 [details]
[Video] With patch applied
Comment on attachment 362839 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362839&action=review r=me Probably unrelated, but when I select multiple properties and press ⌘/, I hit an assertion failure. Models/CSSProperty.js:146:23: CONSOLE ERROR CSS property is already disabled We should probably just remove that assertion. > Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js:164 > + this._toggle(); NIT: we should assert (or even just set it) that the checkbox's state matches the property's `enabled`. console.assert(this._checkboxElement.checked === this.property.enabled); > Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js:423 > + const index = parseInt(this._element.dataset.propertyIndex); Style: this should be `let`. Created attachment 362944 [details]
Patch for landing
Comment on attachment 362944 [details] Patch for landing Clearing flags on attachment: 362944 Committed r242063: <https://trac.webkit.org/changeset/242063> All reviewed patches have been landed. Closing bug. |