| Summary: | Hardcode Visual Viewports on everywhere except iOS WK1 | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | cmarcelo, ews-watchlist, fred.wang, jamesr, koivisto, luiz, rniwa, simon.fraser, tonikitoo, webkit-bug-importer, zalan | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Simon Fraser (smfr)
2019-02-21 19:21:59 PST
Created attachment 362685 [details]
Patch
Comment on attachment 362685 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362685&action=review > Source/WebCore/ChangeLog:11 > + it off now. weird indentation Attachment 362685 [details] did not pass style-queue:
ERROR: Source/WebKitLegacy/mac/ChangeLog:11: Line contains tab character. [whitespace/tab] [5]
ERROR: Source/WebKit/ChangeLog:11: Line contains tab character. [whitespace/tab] [5]
ERROR: Tools/ChangeLog:11: Line contains tab character. [whitespace/tab] [5]
ERROR: Source/WebCore/ChangeLog:11: Line contains tab character. [whitespace/tab] [5]
Total errors found: 4 in 22 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 362685 [details] Patch Attachment 362685 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11241693 New failing tests: scrollingcoordinator/scrolling-tree/toggle-coordinated-frame-scrolling.html Created attachment 362691 [details]
Archive of layout-test-results from ews106 for mac-highsierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Created attachment 362693 [details]
Patch
Comment on attachment 362685 [details] Patch Attachment 362685 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11241665 New failing tests: fast/scrolling/ios/change-scrollability-on-content-resize-nested.html fast/scrolling/ios/change-scrollability-on-content-resize.html Created attachment 362694 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
|