Bug 194928

Summary:

Hardcode Visual Viewports on everywhere except iOS WK1

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cmarcelo, ews-watchlist, fred.wang, jamesr, koivisto, luiz, rniwa, simon.fraser, tonikitoo, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	zalan: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews106 for mac-highsierra-wk2	none
Patch	none
Archive of layout-test-results from ews122 for ios-simulator-wk2	none

Simon Fraser (smfr)

Reported 2019-02-21 19:21:59 PST

Hardcode Visual Viewports on everywhere except iOS WK1

Attachments
Patch (138.71 KB, patch) 2019-02-21 19:27 PST, Simon Fraser (smfr)	zalan: review+ ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews106 for mac-highsierra-wk2 (2.62 MB, application/zip) 2019-02-21 20:47 PST, EWS Watchlist	no flags	Details
Patch (142.71 KB, patch) 2019-02-21 21:14 PST, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.49 MB, application/zip) 2019-02-21 21:16 PST, EWS Watchlist	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2019-02-21 19:27:09 PST

Created attachment 362685 [details] Patch

alan

Comment 2 2019-02-21 19:30:40 PST

Comment on attachment 362685 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362685&action=review > Source/WebCore/ChangeLog:11 > + it off now. weird indentation

EWS Watchlist

Comment 3 2019-02-21 19:30:52 PST

Attachment 362685 [details] did not pass style-queue: ERROR: Source/WebKitLegacy/mac/ChangeLog:11: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebKit/ChangeLog:11: Line contains tab character. [whitespace/tab] [5] ERROR: Tools/ChangeLog:11: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebCore/ChangeLog:11: Line contains tab character. [whitespace/tab] [5] Total errors found: 4 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.

Radar WebKit Bug Importer

Comment 4 2019-02-21 19:42:58 PST

<rdar://problem/48300548>

EWS Watchlist

Comment 5 2019-02-21 20:47:31 PST

Comment on attachment 362685 [details] Patch Attachment 362685 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11241693 New failing tests: scrollingcoordinator/scrolling-tree/toggle-coordinated-frame-scrolling.html

EWS Watchlist

Comment 6 2019-02-21 20:47:33 PST

Created attachment 362691 [details] Archive of layout-test-results from ews106 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

Simon Fraser (smfr)

Comment 7 2019-02-21 21:14:49 PST

Created attachment 362693 [details] Patch

EWS Watchlist

Comment 8 2019-02-21 21:16:31 PST

Comment on attachment 362685 [details] Patch Attachment 362685 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11241665 New failing tests: fast/scrolling/ios/change-scrollability-on-content-resize-nested.html fast/scrolling/ios/change-scrollability-on-content-resize.html

EWS Watchlist

Comment 9 2019-02-21 21:16:33 PST

Created attachment 362694 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

Simon Fraser (smfr)

Comment 10 2019-02-21 23:05:28 PST

https://trac.webkit.org/changeset/241934/webkit

Note You need to log in before you can comment on or make changes to this bug.