| Summary: | scalableNativeWebpageParameters() is not preserved on new page navigation. | ||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yongjun Zhang <yongjun_zhang> | ||||||||||||||||||||
| Component: | Layout and Rendering | Assignee: | Yongjun Zhang <yongjun_zhang> | ||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||
| Severity: | Normal | CC: | bfulgham, commit-queue, ews-watchlist, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh, yongjun_zhang, zalan | ||||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||
|
Description
Yongjun Zhang
2019-02-20 19:41:05 PST
Created attachment 362585 [details]
Patch
Created attachment 362594 [details]
Fix Mac build break.
Comment on attachment 362594 [details] Fix Mac build break. Attachment 362594 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11229089 New failing tests: fast/viewport/ios/minimum-scale-after-changing-view-scale.html Created attachment 362598 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Created attachment 362619 [details]
Fix DRT build break.
Comment on attachment 362619 [details] Fix DRT build break. Attachment 362619 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11234456 New failing tests: fast/viewport/ios/preserve-viewport-shrink-to-fit-on-new-navigation.html fast/viewport/ios/minimum-scale-after-changing-view-scale.html Created attachment 362630 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Created attachment 362642 [details]
Fix a failed layout test.
Comment on attachment 362642 [details] Fix a failed layout test. Attachment 362642 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11237861 New failing tests: fast/viewport/ios/minimum-scale-after-changing-view-scale.html Created attachment 362670 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Created attachment 362768 [details]
Fix a failed layout test again.
Comment on attachment 362768 [details] Fix a failed layout test again. View in context: https://bugs.webkit.org/attachment.cgi?id=362768&action=review > Source/WebCore/page/ViewportConfiguration.cpp:336 > +ViewportConfiguration::Parameters ViewportConfiguration::fixedNativeWebpageParameters() It's somewhat confusing that nativeWebpageParameters splits off into scalableNativeWebpageParameters or fixedNativeWebpageParameters. I think fixedNativeWebpageParameters is a bit of a strange name too (the key point here is that the fixed parameters don't allow shrink to fit, right?) Maybe we can make this more explicit, like... nativeWebpageParameters() returns either nativeWebpageParametersWithShrinkToFit() or nativeWebpageParametersWithoutShrinkToFit()? > Tools/WebKitTestRunner/UIScriptControllerCocoa.mm:60 > + TestController::singleton().mainWebView()->platformView()._allowsViewportShrinkToFit = allows; Nit - I think you could just put this in UIScriptControllerIOS.mm, since _allowsViewportShrinkToFit is only available on iOS. (In reply to Wenson Hsieh from comment #13) > Comment on attachment 362768 [details] > Fix a failed layout test again. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=362768&action=review > > > Source/WebCore/page/ViewportConfiguration.cpp:336 > > +ViewportConfiguration::Parameters ViewportConfiguration::fixedNativeWebpageParameters() > > It's somewhat confusing that nativeWebpageParameters splits off into > scalableNativeWebpageParameters or fixedNativeWebpageParameters. I think > fixedNativeWebpageParameters is a bit of a strange name too (the key point > here is that the fixed parameters don't allow shrink to fit, right?) > > Maybe we can make this more explicit, like... > > nativeWebpageParameters() returns either > nativeWebpageParametersWithShrinkToFit() or > nativeWebpageParametersWithoutShrinkToFit()? > Good point! Will change. > > Tools/WebKitTestRunner/UIScriptControllerCocoa.mm:60 > > + TestController::singleton().mainWebView()->platformView()._allowsViewportShrinkToFit = allows; > > Nit - I think you could just put this in UIScriptControllerIOS.mm, since > _allowsViewportShrinkToFit is only available on iOS. Created attachment 362953 [details]
Address review comments and commit.
Comment on attachment 362953 [details] Address review comments and commit. Clearing flags on attachment: 362953 Committed r242069: <https://trac.webkit.org/changeset/242069> All reviewed patches have been landed. Closing bug. |