Bug 194886

Summary: Make programmatic frame scrolling work on iOS
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: ScrollingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fred.wang, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 196394, 194900    
Attachments:
Description Flags
patch none

Description Antti Koivisto 2019-02-20 17:14:26 PST
Move the UIScrollView
Comment 1 Antti Koivisto 2019-02-20 17:26:13 PST
Created attachment 362576 [details]
patch
Comment 2 Simon Fraser (smfr) 2019-02-20 17:35:34 PST
Comment on attachment 362576 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362576&action=review

> Source/WebKit/ChangeLog:17
> +        Remove scroll origin code, it doesn't look correct (and is untested).

Maybe test it and file a bug or add another test for it?
Comment 3 WebKit Commit Bot 2019-02-20 19:28:16 PST
Comment on attachment 362576 [details]
patch

Clearing flags on attachment: 362576

Committed r241859: <https://trac.webkit.org/changeset/241859>
Comment 4 WebKit Commit Bot 2019-02-20 19:28:18 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-02-20 19:29:25 PST
<rdar://problem/48262612>
Comment 6 Frédéric Wang (:fredw) 2019-02-21 07:40:46 PST
Comment on attachment 362576 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362576&action=review

> LayoutTests/ChangeLog:11
> +        * fast/scrolling/ios/programmatic-scroll-iframe.html: Added.

Just for the record, these tests are taken from attachment 359723 [details] but the fixed/sticky one have been discarded for now (bug 194433).