Bug 194877

Summary:

URL percent-encode operations should use checked arithmetic for buffer allocation length

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, thorton, tsavell, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Alex Christensen

Reported 2019-02-20 15:43:02 PST

URL percent-encode operations should use checked arithmetic for buffer allocation length

Attachments
Patch (2.83 KB, patch) 2019-02-20 15:44 PST, Alex Christensen	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2019-02-20 15:44:08 PST

Created attachment 362556 [details] Patch

Alex Christensen

Comment 2 2019-02-20 15:44:12 PST

<rdar://problem/48212062>

WebKit Commit Bot

Comment 3 2019-02-20 17:36:09 PST

Comment on attachment 362556 [details] Patch Clearing flags on attachment: 362556 Committed r241856: <https://trac.webkit.org/changeset/241856>

WebKit Commit Bot

Comment 4 2019-02-20 17:36:11 PST

All reviewed patches have been landed. Closing bug.

Truitt Savell

Comment 5 2019-02-21 10:18:21 PST

It looks like the changes in https://trac.webkit.org/changeset/241856/webkit most likely caused 5 API failures on Mac Log: https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK2%20%28Tests%29/builds/9628/steps/run-api-tests/logs/stdio build: https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK2%20%28Tests%29/builds/9628

Truitt Savell

Comment 6 2019-02-21 10:45:11 PST

These 5 API tests may be fallout from infrastructure downtime yesterday.

Note You need to log in before you can comment on or make changes to this bug.