| Summary: | Toggling visibility on the <html> element can result in a blank web view | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, koivisto, simon.fraser, tsavell, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=194866 | ||||||
| Attachments: |
|
||||||
|
Description
Simon Fraser (smfr)
2019-02-19 13:24:05 PST
Created attachment 362420 [details]
Patch
Attachment 362420 [details] did not pass style-queue:
ERROR: Source/WebCore/testing/Internals.h:350: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
Total errors found: 1 in 14 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 362420 [details] Patch Clearing flags on attachment: 362420 Committed r241788: <https://trac.webkit.org/changeset/241788> All reviewed patches have been landed. Closing bug. The changes in https://trac.webkit.org/changeset/241788/webkit caused one API timeout on Mojave Debug. Timeout TestWebKitAPI.WebKit.ResizeReversePaginatedWebView _RegisterApplication(), FAILED TO establish the default connection to the WindowServer, _CGSDefaultConnection() is NULL. ASSERTION FAILED: !m_normalFlowListDirty ./rendering/RenderLayer.h(331) : WebCore::RenderLayer::LayerList WebCore::RenderLayer::normalFlowLayers() const 1 0x789fc5329 WTFCrash 2 0x77800c8db WTFCrashWithInfo(int, char const*, char const*, int) 3 0x77b6f26f3 WebCore::RenderLayer::normalFlowLayers() const 4 0x77b71f6ce WebCore::RenderLayerCompositor::recursiveRepaintLayer(WebCore::RenderLayer&) 5 0x77b71f732 WebCore::RenderLayerCompositor::recursiveRepaintLayer(WebCore::RenderLayer&) 6 0x77b71f565 WebCore::RenderLayerCompositor::repaintCompositedLayers() Run it is present on: https://build.webkit.org/builders/Apple%20Mojave%20Debug%20WK2%20%28Tests%29/builds/1655 reproduced and confirmed locally. Fixing via bug 194866. |